Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get_metadata deprecated since traitlets 4.1 #3894

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

ManonMarchand
Copy link
Contributor

@ManonMarchand ManonMarchand commented Mar 15, 2024

Hello,

This is a very tiny PR, but I get a deprecation warning raised by this line from the traitlets library when using a custom ipywidget:

https://github.com/ipython/traitlets/blob/cb672eb5ba235fdfee6407bd7f1b1985de934e7c/traitlets/traitlets.py#L833

Here is a fix that should remove it?

Edit: I explicitly allow anyone to edit anything I might have done wrong, I have no idea why the tests are failing

Copy link

Binder 👈 Launch a binder notebook on branch ManonMarchand/ipywidgets/fix-get_metadata

@dangotbanned
Copy link

dangotbanned commented Aug 5, 2024

@ManonMarchand could you push this again please?

I can try to help with CI failures, but the original logs aren't visible anymore.

Arrived here after planning to submit an identical PR for vega/altair#3234

@ManonMarchand
Copy link
Contributor Author

ManonMarchand commented Aug 5, 2024

Sure, also rebased on main in case the ci failure wasn't due to the tiny fix

@dangotbanned
Copy link

dangotbanned commented Aug 5, 2024

@ManonMarchand looking at the last 4 merged commits, I don't think you should expect anything other than the last 4 tests passing

image

I've tried using that auto binder link #3894 (comment)
No idea what the expectation there is, but it spent 45 mins building and then printed "Service Unavailable".


I think a maintainer will just need to merge as-is.
The failures are already on main and seems very unlikely to me that your change has anything to do with it.

There is also #3932 which seems to be passing CI, but is yet to be reviewed

@martinRenou
Copy link
Member

martinRenou commented Aug 21, 2024

I will try a patch release very soon-ish with this and #3932, thanks @ManonMarchand !

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 72b9397 into jupyter-widgets:main Aug 21, 2024
19 of 20 checks passed
@ManonMarchand ManonMarchand deleted the fix-get_metadata branch August 30, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants