Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get JUPYTERHUB_API_TOKEN from secret #693

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NarekA
Copy link

@NarekA NarekA commented Jan 6, 2023

Trying to reslove #398

This might be redundant from #471

@welcome
Copy link

welcome bot commented Jan 6, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

kubespawner/objects.py Outdated Show resolved Hide resolved
Co-authored-by: Maxim Martynov <[email protected]>
name="JUPYTERHUB_API_TOKEN",
value_from=V1EnvVarSource(
secret_key_ref=V1SecretKeySelector(
name=user_secret_name, key="JUPYTERHUB_API_TOKEN"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why secret ref name is configurable, but secret name itself is not?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ref has to be unique per user, so we need to pass it the user name.

@sstarcher
Copy link
Contributor

@NarekA @dolfinus any engagement on this? Anyone else able to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants