Installing jupyterlab-lsp and jupyter-lsp breaks the completer plugin

[divyansshhh]

Description

I want to use the completions from the default completer extension and features from lsp but I don't want to use the lsp code completion. When I install jupyterlab-lsp and jupyter-lsp in my environment, I can't see any availableProviders in the completer extension settings.

Here's the screenshot -

Reproduce

1. Install and launch jupyterlab
2. Go to the completer extension settings. You'll see kernel and context providers are available.
3. Install jupyter-lsp and jupyterlab-lsp
4. Go to the completer extension settings again. You'll see that the kernel and context providers are no longer available.

Expected behavior

I expect the default completer extension to work regardless of lsp packages being installed or not.

Context

Versions used -

• jupyterlab 4.0.10
• jupyter-lsp 2.2.1
• jupyterlab-lsp 5.0.1

[krassowski]

I cannot reproduce this:

I expect the default completer extension to work regardless of lsp packages being installed or not.

Is there something which does not work?

I want to use the completions from the default completer extension and features from lsp but I don't want to use the lsp code completion

For now I would recommend disabling the @jupyter-lsp/jupyterlab-lsp:completion plugin,.

[krassowski]

Are there any errors in the browsers JS console?

[divyansshhh]

Is there something which does not work?

I'm not getting any completion suggestions when pressing Tab.

For now I would recommend disabling the @jupyter-lsp/jupyterlab-lsp:completion plugin,.

Yes, we intend to disable this for now.

Are there any errors in the browsers JS console?

No, there are no errors. Neither in the terminal nor in the browser console.

Any thoughts on why these completers are not present? I'm trying to make a better reproducer in the meantime.

FWIW, I tried doing a dev build and setting a breakpoint in the activate function of the default providers but the breakpoint never got triggered.

[divyansshhh]

Here's a screen capture of this (if it helps) -

lsp.mp4

[divyansshhh]

@krassowski can you disable @jupyter-lsp/jupyterlab-lsp:completion and then try to look into the completer-extension settings? I'm consistently able to reproduce this by toggling the jupyterlab-lsp:completion extension.

[krassowski]

Yes, disabling @jupyter-lsp/jupyterlab-lsp:completion plugin does make it reproducible - thank you! Interesting, I will take a look.

[krassowski]

The problem is in the jupyterlab-lsp extension; it disables @jupyterlab/completer-extension:base-service in disabledExtensions because it needs to augment the default providers slightly to work correctly in the context of document tranclusions, and to provide a unified UX regardless of completion source (overrides.ts).

There are a few solutions to consider:

• (a) make it possible to disable a plugin from a plugin level rather than from an extension level; e.g. we could have:

  {
    "jupyterlab": {
       "disabledExtensions": [
          // short form
          "@org/core-extension:plugin-a",
          // proposed long form
          {"disable": "@org/core-extension:plugin-b", "ifEnabled": "@org/external-extension:plugin"}
      ]
    }
  }

  or we could add a new explicit stanza:

  {
    "jupyterlab": {
       "replacesPlugins": {
          "@org/core-extension:plugin-b", "@org/external-extension:plugin"
        }
    }
  }

• (b) make the default completion providers extensible by using hooks; this would be better if multiple extensions want to make small tweaks in their behaviour

In the meantime I will make jupyterlab-lsp re-register the original providers in LSP when the completion plugin is disabled.

[krassowski]

I opened a dedicated issue to discuss the (a) option: #15651 and there is
a draft PR working the issue around in jupyterlab-lsp: jupyter-lsp/jupyterlab-lsp#1036