Re-register native completion providers when LSP completion is disabled #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
krassowski
force-pushed
the
fix-disabling-completion
branch
from
99f8263 to
a7c7576
Compare
even when lsp is off (with type "Statement" in CM6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes jupyterlab/jupyterlab#15649
Code changes
Adds a new
@jupyter-lsp/jupyterlab-lsp:completion-fallbackplugin which checks whether@jupyter-lsp/jupyterlab-lsp:completionwas disabled by probing whether an optional token from it is available; if it sees our custom completion disabled it re-registers the native completion providers.User-facing changes
When LSP completion is disabled (by disabling plugin or by using the "disable" option) the native completer will still work.
Backwards-incompatible changes
None