Run on Node 20 #66
Merged
Run on Node 20 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add @types/node to devDependencies to ensure we get the proper version and bump @vercel/ncc to the latest, and update package-lock using `npm install` which also prepares the package.
jwlawson
approved these changes
Feb 5, 2024
|
This is great news. I look forward to have this merged and tagged |
Cool, I bumped the major version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub is no longer going to support running actions on Node 16 and requires upgrading to Node 20 (see blog). This PR addresses that with updates to:
Tests passed when run locally. Closes #65.
I didn't update the version in package.json because I wasn't sure what type of bump was preferred. I'm happy to add another commit to handle it. The official GitHub actions that I've seen are treating this as a major version bump, so up to v2.0.0. Is following their lead acceptable?