Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable vector API #1433

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JBOClara
Copy link
Contributor

What this PR does:
This PR introduces the ability to enable the Vector API within the telemetry configuration. A new ApiConfig struct is added to VectorSpec to handle the API's enablement. If enabled is set to true in the telemetry specification, the API configuration will be included in the generated Vector TOML configuration.

Functional Changes:

  • Added an ApiConfig struct to the VectorSpec.
  • The behavior to enable the API if the enabled property is set to true in the ApiConfig.

Technical Changes:

  • Updates in telemetry_types.go to add the new ApiConfig.
  • Modifications in vector.go to check the enabled property and configure the Vector TOML accordingly.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@JBOClara
Copy link
Contributor Author

Hi @adejanovski,

What do you think about this change?

Copy link

sonarcloud bot commented Oct 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant