Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Respect always-persist-timestamp-in-utc in Spring Starter (#487) #490

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: Respect always-persist-timestamp-in-utc in Spring Starter (#487) #490

merged 2 commits into from
May 28, 2024

Conversation

GeorgEchterling
Copy link
Contributor

Brief, plain english overview of your changes here

I've changed the Spring Boot auto-configuration to ensure that the jdbcCustomization default does not override the configured alwaysPersistTimestampInUTC default. The previous orElse part is not necessary because the correct jdbcCustomization default later gets applied in SchedulerBuilder#build.

Fixes

Fixes #487

Reminders

  • Added/ran automated tests
    • I don't know how to add an efficient test for this.
    • I ran the tests but I got an unrelated error in an Oracle compatibility test, even without this change.
  • Update README and/or examples
    • I don't think this is relevant.
  • Ran mvn spotless:apply
    • This only changed unrelated code.

cc @kagkarlsson

@GeorgEchterling
Copy link
Contributor Author

The CI failures seem to be unrelated to this PR.

kagkarlsson
kagkarlsson approved these changes May 28, 2024
View reviewed changes
Copy link
Owner

@kagkarlsson kagkarlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing 🙏

@kagkarlsson kagkarlsson merged commit b0e981b into kagkarlsson:master May 28, 2024
2 of 5 checks passed
@kagkarlsson kagkarlsson added the released Issue has been released label Jun 5, 2024
@kagkarlsson
Copy link
Owner

🎉 This issue has been resolved in v14.0.1 (Release Notes)

@GeorgEchterling GeorgEchterling deleted the bugfix/issue-487-always-persist-timestamp-in-utc branch June 21, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kagkarlsson kagkarlsson kagkarlsson approved these changes

Assignees
No one assigned
Labels
released Issue has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spring Boot: always-persist-timestamp-in-utc has no effect
2 participants
@GeorgEchterling @kagkarlsson