Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New interface SchedulerListener #504

Merged
merged 16 commits into from
Jul 23, 2024
Merged

Conversation

kagkarlsson
Copy link
Owner

@kagkarlsson kagkarlsson commented Jun 20, 2024

Replaces the old StatsRegistry and adds more detailed events:

  void onExecutionScheduled(TaskInstanceId taskInstanceId, Instant executionTime);
  void onExecutionStart(CurrentlyExecuting currentlyExecuting);
  void onExecutionComplete(ExecutionComplete executionComplete);
  void onExecutionDead(Execution execution);
  void onExecutionFailedHeartbeat(CurrentlyExecuting currentlyExecuting);

Additionally adds ExecutionInterceptor as a way of injecting wrapping-logic for all executions.

  CompletionHandler<?> execute(
      TaskInstance<?> taskInstance, ExecutionContext executionContext, ExecutionChain chain);

Fixes

@kagkarlsson kagkarlsson mentioned this pull request Jun 20, 2024
3 tasks
@kagkarlsson kagkarlsson marked this pull request as ready for review June 21, 2024 21:06
@kagkarlsson
Copy link
Owner Author

Tbh I am starting to feel an interceptor/filter/decorator approach is more flexible for injecting logic before and after execution 🤔 (since we still have start-variables in scope after execution is done)

@kagkarlsson kagkarlsson merged commit d09ecbd into master Jul 23, 2024
14 checks passed
@kagkarlsson
Copy link
Owner Author

🎉 This issue has been resolved in v14.1.0 (Release Notes)

@kagkarlsson kagkarlsson added the released Issue has been released label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant