Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat image segmentation datasets #380

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Reformat image segmentation datasets #380

merged 4 commits into from
Apr 22, 2024

Conversation

ioangatop
Copy link
Collaborator

Closes #379

@ioangatop ioangatop requested review from roman807 and nkaenzig April 22, 2024 09:10
@ioangatop ioangatop self-assigned this Apr 22, 2024
@ioangatop ioangatop linked an issue Apr 22, 2024 that may be closed by this pull request
Fixes on segmentation base class and TotalSegmentator2D dataset #379
Closed
@ioangatop ioangatop marked this pull request as ready for review April 22, 2024 09:23
@ioangatop ioangatop enabled auto-merge (squash) April 22, 2024 09:23
nkaenzig
nkaenzig reviewed Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@nkaenzig nkaenzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Left some minor comments

src/eva/vision/data/datasets/segmentation/total_segmentator.py Show resolved Hide resolved
src/eva/vision/utils/io/nifti.py Outdated Show resolved Hide resolved
src/eva/vision/data/datasets/segmentation/total_segmentator.py Show resolved Hide resolved
src/eva/vision/data/datasets/segmentation/total_segmentator.py Show resolved Hide resolved
nkaenzig
nkaenzig approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@nkaenzig nkaenzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioangatop ioangatop merged commit 767fbbd into main Apr 22, 2024
5 checks passed
@ioangatop ioangatop deleted the 379-fixes-on-segmentation-base-class-and-totalsegmentator2d-dataset branch April 22, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkaenzig nkaenzig nkaenzig approved these changes

@roman807 roman807 Awaiting requested review from roman807

Assignees

@ioangatop ioangatop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixes on segmentation base class and TotalSegmentator2D dataset
2 participants
@ioangatop @nkaenzig