Refactoring #451
Merged
Refactoring #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
…e replaced with enhanced for loop Signed-off-by: Sergey Ponomarev <[email protected]>
…ssion replaceable by 'Objects.equals()' expression Signed-off-by: Sergey Ponomarev <[email protected]>
…n be replaced with '<>' Signed-off-by: Sergey Ponomarev <[email protected]>
…)' expression can be replaced with 'contains()' Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
…xing Signed-off-by: Sergey Ponomarev <[email protected]>
… be replaced with enhanced 'for' loop Signed-off-by: Sergey Ponomarev <[email protected]>
…an be replaced with lambda Signed-off-by: Sergey Ponomarev <[email protected]>
…aced with 'Collection.removeIf()' Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
…y()' Signed-off-by: Sergey Ponomarev <[email protected]>
…t()' can be replaced with 'List.sort()' Signed-off-by: Sergey Ponomarev <[email protected]>
…sEmpty()' Signed-off-by: Sergey Ponomarev <[email protected]>
The 'String.equals("")' can be replaced with 'String.isEmpty()'
Signed-off-by: Sergey Ponomarev <[email protected]>
…y string Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
…replaced with 'String' Signed-off-by: Sergey Ponomarev <[email protected]>
… StringBuilder Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
The file.length() is an int and the 1024 is an int too and not a float like 1024.0. So here we have an integer division rounded down. But then we are converting the number to float and rounding it but there is nothing to round anymore. So the Math.round() can be eliminated. Signed-off-by: Sergey Ponomarev <[email protected]>
The equals var is an int and the rows.size() is an int too and not a float. So here we have an integer division rounded down. But then we are converting the int to float. Then the float is formatted but it remains rounded. Instead we can just avoid the float conversion. Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
…ted using 'Files' methods Signed-off-by: Sergey Ponomarev <[email protected]>
Fix a/an articles back space -> backspace web site -> website Signed-off-by: Sergey Ponomarev <[email protected]>
|
You can install the IntelliJ COmmunity Edition for free, it's open source. But you will need to open not a parent directory but kse instead and the IntelliJ will find the Gradle and import the project properly. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using IntelliJ IDE and it has a lot of code inspections. Most of them can be fixed automatically and safely.
I just runned Analyze Code and fixed those problems that definitely should be fixed.
When fixed I committed with a comment of the inspection name.
This is only refactoring and you can safely merge the PR.