V2 #54
Merged
V2 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still need to test actual connections and split long base64 lines.
remove incorrect example from README
base64 split lost one char send 'QUIT' before closing socket close all streams when socket closes. close socket in finally use correct type for addresses (Iterable instead of List) remove unnecessary `new`
provide verbose flag in send_gmail fix port for gmail smtp server to default remove adapter.dart and move functionality to other files.
library now works in both dart1 and dart2!
Closed
even if smtp server supports SMTPUTF8 The text could for instance contain \r\n...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!PLEASE TEST!
2018-09-03: This is now a release candidate.
Unless a bug is found I will merge this in ~1 week.
fixes #2 1MiB attachment took < 1 second on local SMTP server
fixes #32 All parts are UTF8/ base64 encoded.
mostly fixes #35 We use UTF8 when server announces SMTPUTF8. Mail-addresses are not correctly handled yet (see #33 and #34)
fixes #37 all EOLs are replaced with
\r\n. I don't know if anything else should be done.fixes #38 Text headers are base64 encoded if there are unicode characters and SMTPUTF8 is not present.
probably fixes #45 The multiparts use a different structure now.
I don't know of any regression to version 1.*
This will become mailer version 2.
Practically everything has been rewritten.
Comments are welcome!
@kaisellgren I have removed the address validation code, but think it should become its own library.