Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oxidize Hafnium's initialization sequence (successor of #45) #52

Merged
merged 50 commits into from
Sep 11, 2019
Merged

Oxidize Hafnium's initialization sequence (successor of #45) #52

merged 50 commits into from
Sep 11, 2019

Conversation

efenniht
Copy link
Collaborator

#45 가 너무 커져서 다시 만드는 PR입니다. #45의 리뷰를 딱 하나 남기고 다 resolve 했습니다. 남은 것은:

  • one_time_init에서 INITED 변수를 확인하고 업데이트합니다. INITED 변수는 사실 atomic할 필요는 없는데, 그래도 AtomicBool로 만들까요..? (다른 pCPU가 INITED를 읽을 때까지 INITED = true가 실행되지 않을 수 있을까요?)
  • boot_cpu의 stack_bottom을 어셈블리에서 초기화하려면 어셈블리 코드를 고쳐야 하는데, 아마 이전 hypervisor_entry 를 수정하는 정도의 어셈블리 수정이 일어날 것 같습니다. 이것은 하지 않는 게 좋지 않을까요?

Closes #32.

@efenniht
Oxidize load.c and main.c
00a1f2d
@efenniht
Oxidize unit test code (abi_test.cc)
bc7ca9f
@efenniht
Remove c++ test codes and add cargo test in test script.
2636ccc
@efenniht
Oxidize FDT
30e6ded
@efenniht
Oxidize FDT (cont'd).
864fa4e
@efenniht
Export C functions.
8a640d8
@efenniht
Format and fix to call fdt_handler::{map, unmap, patch}.
172c40a
@efenniht
Remove plat.rs, since #pragma weak is not supported in Rust. Make s…
05accd4 
…afe wrapper functions instead.
@efenniht
Refactor init, load, boot_params
77b1dc8
@efenniht
Fix wrongly ported code (!*p should be *p == 0)
d21425f
@efenniht
Fix wrongly ported code (write to the given reference, and continue e…
c1e4486 
…valuates condition expression in do-while loop)
@efenniht
Use different constants for unit tests.
f2fba0f
@efenniht
Resolve warnings on FDT and FDT handler.
aa8020d
@efenniht
Make a singleton object representing MemoryManager.
4d1e6a9
@efenniht
rustfmt.
14c7d6e
@efenniht
Resolve some clippy issues.
4677f7c
@efenniht
Fix mem_ranges_available to be initialized properly
4b85b64
@efenniht
Refactor VM init sequence.
fc87686
@efenniht
Refactor load_secondary.
896d267
@efenniht
Refactor VM init sequence. (cont'd)
be86a72
@efenniht
Refactor API init sequence.
16c7781
@efenniht
Remove vm_find.
7d75af6
@efenniht
Refactor CPU init sequence.
7dbad0b
@efenniht
Correct one-time initialization to run
0a9cb50
@efenniht
Make safe wrapper functions to read singletons.
d6b350b
@efenniht
Fix Vm to know its address correctly while initialized
7dac8a4
@efenniht
Remove unused imports
54c3e18
@efenniht
Resolve simple issues on the review of kaist-cp#45
eebc853
@efenniht
More idiomatic init of Cpu
9e52fae
@efenniht
Resolve simple issues on the review of kaist-cp#45 (cont'd)
cfdb622
@efenniht efenniht self-assigned this Sep 11, 2019
jeehoonkang
jeehoonkang reviewed Sep 11, 2019
View reviewed changes
src/arch/aarch64/hypervisor/hypervisor_entry.S Outdated Show resolved Hide resolved
hfo2/src/api.rs Outdated Show resolved Hide resolved
hfo2/src/api.rs Outdated Show resolved Hide resolved
hfo2/src/api.rs Show resolved Hide resolved
hfo2/src/api.rs Show resolved Hide resolved
hfo2/src/cpu.rs Show resolved Hide resolved
hfo2/src/mm.rs Outdated Show resolved Hide resolved
hfo2/src/fdt_handler.rs Outdated Show resolved Hide resolved
hfo2/src/fdt.rs Outdated Show resolved Hide resolved
jeehoonkang
jeehoonkang reviewed Sep 11, 2019
View reviewed changes
hfo2/src/fdt.rs Outdated Show resolved Hide resolved
hfo2/src/api.rs Show resolved Hide resolved
jeehoonkang
jeehoonkang reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@jeehoonkang jeehoonkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 한두개 빼고 다 정리된 것 같아요. 고생하셨습니다.

@efenniht
Copy link
Collaborator Author

아래 두 개는 어떻게 할까요?

  • one_time_init에서 INITED 변수를 확인하고 업데이트합니다. INITED 변수는 사실 atomic할 필요는 없는데, 그래도 AtomicBool로 만들까요..? (다른 pCPU가 INITED를 읽을 때까지 INITED = true가 실행되지 않을 수 있을까요?)
  • boot_cpu의 stack_bottom을 어셈블리에서 초기화하려면 어셈블리 코드를 고쳐야 하는데, 아마 이전 hypervisor_entry 를 수정하는 정도의 어셈블리 수정이 일어날 것 같습니다. 이것은 하지 않는 게 좋지 않을까요?

@jeehoonkang
Copy link
Member

INITED 타입 변경, stack_bottom 초기화는 일단 하지 맙시다.

@efenniht
Copy link
Collaborator Author

INITED 타입을 변경하고, issue들을 만들고, review를 모두 resolve 했습니다. 🚀🚀

@jeehoonkang jeehoonkang merged commit a12d91d into kaist-cp:hfo2 Sep 11, 2019
jeehoonkang pushed a commit that referenced this pull request Sep 11, 2019
@efenniht @jeehoonkang
Resolve simple issues on the review of #52
0cb72ec
@jeehoonkang
Copy link
Member

고생하셨습니다! 넉넉한 한가위 보내세요-

@efenniht
Copy link
Collaborator Author

새벽까지 신경써주셔서 감사합니다 ㅠㅠ 추석 잘 보내세요 :)

@efenniht efenniht deleted the hfo2-loadmain branch September 11, 2019 18:15
efenniht added a commit to efenniht/hafnium-verification that referenced this pull request Nov 13, 2019
@efenniht
Resolve simple issues on the review of kaist-cp#52
6beb763
efenniht added a commit that referenced this pull request Nov 26, 2019
@efenniht @hkim15
Resolve simple issues on the review of #52
56961fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeehoonkang jeehoonkang jeehoonkang left review comments

Assignees

@efenniht efenniht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remaining C files
2 participants
@efenniht @jeehoonkang