Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZIO-Kafka version #31

Closed
wants to merge 2 commits into from
Closed

Conversation

yisraelU
Copy link

@yisraelU yisraelU commented Sep 7, 2023

this will upgrade kafka client version and remove CVE related to earlier Kafka Clients

this will upgrade kafka client version and remove CVE related to earlier Kafka Clients
@yisraelU
Copy link
Author

yisraelU commented Sep 7, 2023

Well apparently the interface was changed, so this is no longer a simple single-character PR 🤣
I did try to implement it correctly , but not entirely confident on the best way to deal with the new infallible method as it doesnt allow allow an unhappy path, and tracing requires an unhappy path.

@soujiro32167
Copy link
Collaborator

Thanks @yisraelU ! I'll take a look

@soujiro32167
Copy link
Collaborator

you'd think that such an API change would get a minor version update...

@yisraelU
Copy link
Author

yisraelU commented Sep 8, 2023

you'd think that such an API change would get a minor version update...

absolutely !!

@soujiro32167
Copy link
Collaborator

Given there are no better ways to compose producers, I don't see a way to improve here...
@calvinlfer @anakos what do you think?
I'm going to open a ticket on zio-kafka to create composition functions, so this kind of middleware is easier

@soujiro32167
Copy link
Collaborator

zio/zio-kafka#1039

You have my thanks and 👍

@yisraelU
Copy link
Author

yisraelU commented Sep 8, 2023

Given there are no better ways to compose producers, I don't see a way to improve here...
@calvinlfer @anakos what do you think?
I'm going to open a ticket on zio-kafka to create composition functions, so this kind of middleware is easier

A side note , I'm not sure if the whole nested effect thing is a good interface for a public api for modeling 2 layers of async

@calvinlfer
Copy link
Member

Superseded by #32

@calvinlfer calvinlfer closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants