Update run_relax option to models_to_relax #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh actually the commit that I am referring to happened after the release of 2.3.1. It is in the current main branch though. I cloned the alphafold main repo instead of using the 2.3.1 one following the instruction in readme. Maybe it is a good idea to wait until this becomes an actually release? |
|
Hi @dxu16, first of all, sorry for the delayed response. Second, thank you for participating. I will look into this issue soon but it seems to become an issue when Alphafold renames that flag in their next release. Best, Roman |
PasqM
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In alphafold 2.3.1 the option run_relax was changed to models_to_relax (google-deepmind/alphafold@684ffa1). I modified the code in respective places to reflect the change, and set the default value to 'all' (which is consistent with the previous behavior).