Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic wrapper around MPI_Group #663

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Conversation

lukashuebner
Copy link
Member

@lukashuebner lukashuebner commented Mar 6, 2024

This wrapper is not feature complete but provides a basic abstraction which should be enough to use it in the FaultTolerance plugin.

Features not implemented yet: #664

@lukashuebner lukashuebner self-assigned this Mar 6, 2024
@lukashuebner lukashuebner added this to the Publication milestone Mar 6, 2024
@lukashuebner lukashuebner added the feature New feature or request label Mar 6, 2024
@lukashuebner lukashuebner added the review Ready for review label Mar 6, 2024
Copy link
Member

@niklas-uhl niklas-uhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, aside from two minor suggestions

include/kamping/group.hpp Outdated Show resolved Hide resolved
tests/mpi_group_test.cpp Outdated Show resolved Hide resolved
@lukashuebner lukashuebner merged commit 0f57f4c into main Mar 7, 2024
8 checks passed
@lukashuebner lukashuebner deleted the feature/basic-group branch March 7, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants