Fix #78 pass AdditionalToolArguments for SVGO

kamsar · Nov 14, 2020 · 5039b1b · 5039b1b
1 parent 6cf19f1
commit 5039b1b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Dianoga.Tests/Optimizers/Pipelines/DianogaSvg/SvgOptimizerTests.cs b/src/Dianoga.Tests/Optimizers/Pipelines/DianogaSvg/SvgOptimizerTests.cs
@@ -27,6 +27,16 @@ public void ShouldSquishSmallSvg()
 			args.IsOptimized.Should().BeTrue();
 		}
 
+		[Fact]
+		public void ShouldSquishSmallSvgWithArgs()
+		{
+			Test(@"TestImages\small.svg",
+				@"..\..\..\..\Dianoga\Dianoga Tools\SVGO\svgop.exe",
+				"--disable=removeViewBox", out var args, out var startingSize);
+			args.Stream.Length.Should().BeLessThan(startingSize).And.BeGreaterThan(0);
+			args.IsOptimized.Should().BeTrue();
+		}
+
 		[Fact]
 		public void ShouldSquishLargeSvg()
 		{

diff --git a/src/Dianoga/Optimizers/Pipelines/DianogaSvg/SvgoOptimizer.cs b/src/Dianoga/Optimizers/Pipelines/DianogaSvg/SvgoOptimizer.cs
@@ -21,6 +21,7 @@ protected void ExecuteProcess(OptimizerArgs args)
 			using (Process toolProcess = new Process())
 			{
 				toolProcess.StartInfo.FileName = ExePath;
+				toolProcess.StartInfo.Arguments = AdditionalToolArguments;
 				toolProcess.StartInfo.UseShellExecute = false;
 				toolProcess.StartInfo.RedirectStandardInput = true;
 				toolProcess.StartInfo.RedirectStandardOutput = true;
@@ -30,7 +31,7 @@ protected void ExecuteProcess(OptimizerArgs args)
 				toolProcess.ErrorDataReceived += (sender, eventArgs) => processOutput.Add(eventArgs.Data);
 
 #if DEBUG
-				Sitecore.Diagnostics.Log.Info($"\"{ExePath}\"", this);
+				Sitecore.Diagnostics.Log.Info($"\"{ExePath} {AdditionalToolArguments}\"", this);
 #endif
 
 				try