bug fix: when input object is not a valid JSON object, in - (void)put… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Object:(id)object withId:(NSString *)objectId intoTable:(NSString *)tableName, do NOT throw an exception
tangqiaoboy
reviewed
Oct 15, 2016
| NSError * error; | ||
| NSData * data = [NSJSONSerialization dataWithJSONObject:object options:0 error:&error]; | ||
| if (error) { | ||
| if([NSJSONSerialization isValidJSONObject:object] == NO){ | ||
| debugLog(@"ERROR, faild to get json data"); |
There was a problem hiding this comment.
当传入参数不是合法 JSON 对象时，dataWithJSONObject 会 crash。 AFNetworking 前几天做了类似的改动 AFNetworking/AFNetworking@719a3bf
There was a problem hiding this comment.
不过考虑到暴露出的 API 没有通过 error 或者返回值报告操作成功与否，只是打出了 log。相比之下，Crash 也不失为一种报错的方式。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Object:(id)object withId:(NSString *)objectId intoTable:(NSString *)tableName, do NOT throw an exception