Abort. Immutable JSO interfaces

karakum-team · Oct 9, 2024 · ab04ec7 · ab04ec7
1 parent 8fae8fa
commit ab04ec7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/buildSrc/src/main/kotlin/karakum/browser/Abortable.kt b/buildSrc/src/main/kotlin/karakum/browser/Abortable.kt
@@ -9,7 +9,7 @@ external interface Abortable {
     /**
      * When provided the corresponding `AbortController` can be used to cancel an asynchronous action.
      */
-    var signal: AbortSignal?
+    val signal: AbortSignal?
 }
 """.trimIndent()
 

diff --git a/buildSrc/src/main/kotlin/karakum/browser/Html.kt b/buildSrc/src/main/kotlin/karakum/browser/Html.kt
@@ -1179,8 +1179,6 @@ internal fun convertInterface(
         !declaration.startsWith("interface ") -> ""
         "= definedExternally" in members -> ""
 
-        name.endsWith("Options") -> "@JsPlainObject"
-
         IDLRegistry.isPlainObjectInterface(name) -> {
             when (name) {
                 "QueuingStrategy",

diff --git a/buildSrc/src/main/kotlin/karakum/browser/IDL.kt b/buildSrc/src/main/kotlin/karakum/browser/IDL.kt
@@ -345,5 +345,5 @@ internal object IDLRegistry {
     fun isPlainObjectInterface(
         name: String,
     ): Boolean =
-        name in plainObjectInterfaces
+        name in plainObjectInterfaces || name.endsWith("Options")
 }