-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor font manager and implement bitmap font generator. #788
Merged
andy840119
merged 10 commits into
karaoke-dev:master
from
andy840119:refactor-font-manager
Jul 29, 2021
Merged
Refactor font manager and implement bitmap font generator. #788
andy840119
merged 10 commits into
karaoke-dev:master
from
andy840119:refactor-font-manager
Jul 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and this shit only use in gameplay and editor (and config page). placing it at root namespace might iet it feels too general.
not by game host. also should register this manager.
…ont info (mainly for export purpose).
Also add object assert fot compare two objects by parsing to json format.
also add testing for the case with generate multi line and multi page characters.
and add a test to make sure that it will generate same image as source.
Note: this is the big step in creating customize font in the skin. |
note: |
Also note that it's a big step for #787 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what's done in this pr:
skin/fonts
GetGlyphStore
into font manager.