add cron-fhpa validation unit-test

Signed-off-by: whitewindmills <[email protected]>
karmada-io · Jul 31, 2023 · b234492 · b234492
1 parent f160ea7
commit b234492
Showing 1 changed file with 296 additions and 0 deletions.
diff --git a/pkg/webhook/cronfederatedhpa/validating_test.go b/pkg/webhook/cronfederatedhpa/validating_test.go
@@ -0,0 +1,296 @@
+package cronfederatedhpa
+
+import (
+	"fmt"
+	"strings"
+	"testing"
+
+	autoscalingv2 "k8s.io/api/autoscaling/v2"
+	"k8s.io/apimachinery/pkg/util/validation/field"
+	"k8s.io/utils/pointer"
+
+	autoscalingv1alpha1 "github.com/karmada-io/karmada/pkg/apis/autoscaling/v1alpha1"
+)
+
+func Test_validateCronFederatedHPASpec(t *testing.T) {
+	specFld := field.NewPath("spec")
+
+	tests := []struct {
+		name        string
+		spec        *autoscalingv1alpha1.CronFederatedHPASpec
+		expectedErr string
+	}{
+		{
+			name: "normal Deployment",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					APIVersion: "apps/v1",
+					Kind:       "Deployment",
+					Name:       "foo",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:           "bar",
+						Schedule:       "0 0 13 * 5",
+						TargetReplicas: pointer.Int32(1),
+					},
+				},
+			},
+			expectedErr: "",
+		},
+		{
+			name: "normal FederatedHPA",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					APIVersion: autoscalingv1alpha1.GroupVersion.String(),
+					Kind:       autoscalingv1alpha1.FederatedHPAKind,
+					Name:       "bar",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:              "foo",
+						Schedule:          "0 0 13 * 1",
+						TargetReplicas:    pointer.Int32(2),
+						TargetMinReplicas: pointer.Int32(1),
+						TargetMaxReplicas: pointer.Int32(3),
+					},
+				},
+			},
+			expectedErr: "",
+		},
+		{
+			name: "unsupported kind in apiVersion: autoscaling.karmada.io/v1alpha1",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					APIVersion: autoscalingv1alpha1.GroupVersion.String(),
+					Kind:       "Test",
+					Name:       "foo",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:           "bar",
+						Schedule:       "0 0 13 * 5",
+						TargetReplicas: pointer.Int32(1),
+					},
+				},
+			},
+			expectedErr: fmt.Sprintf("invalid scaleTargetRef kind: %s, only support %s", "Test", autoscalingv1alpha1.FederatedHPAKind),
+		},
+		{
+			name: "unspecified spec.scaleTargetRef.kind",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					Name: "foo",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:           "bar",
+						Schedule:       "0 0 13 * 5",
+						TargetReplicas: pointer.Int32(1),
+					},
+				},
+			},
+			expectedErr: "spec.scaleTargetRef.kind: Required value",
+		},
+		{
+			name: "unspecified spec.scaleTargetRef.name",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					Kind: "foo",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:           "bar",
+						Schedule:       "0 0 13 * 5",
+						TargetReplicas: pointer.Int32(1),
+					},
+				},
+			},
+			expectedErr: "spec.scaleTargetRef.name: Required value",
+		},
+		{
+			name: "duplicated spec.rules[*].name",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					Kind: "foo",
+					Name: "bar",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:           "bar",
+						Schedule:       "0 0 13 * 5",
+						TargetReplicas: pointer.Int32(1),
+					},
+					{
+						Name:           "bar",
+						Schedule:       "0 0 13 * 5",
+						TargetReplicas: pointer.Int32(1),
+					},
+				},
+			},
+			expectedErr: `Duplicate value: "bar"`,
+		},
+		{
+			name: "invalid cron",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					Kind: "foo",
+					Name: "bar",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:           "bar",
+						Schedule:       "0 0 13 *",
+						TargetReplicas: pointer.Int32(1),
+					},
+				},
+			},
+			expectedErr: "invalid cron format",
+		},
+		{
+			name: "invalid timezone",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					Kind: "foo",
+					Name: "bar",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:           "bar",
+						Schedule:       "0 0 13 * 1",
+						TimeZone:       pointer.String("A/B"),
+						TargetReplicas: pointer.Int32(1),
+					},
+				},
+			},
+			expectedErr: "unknown time zone A/B",
+		},
+		{
+			name: "nil targetReplicas",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					Kind: "foo",
+					Name: "bar",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:     "bar",
+						Schedule: "0 0 13 * 1",
+					},
+				},
+			},
+			expectedErr: "targetReplicas cannot be nil if you want to scale foo",
+		},
+		{
+			name: "targetReplicas is less than 0",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					Kind: "foo",
+					Name: "bar",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:           "bar",
+						Schedule:       "0 0 13 * 1",
+						TargetReplicas: pointer.Int32(-1),
+					},
+				},
+			},
+			expectedErr: "targetReplicas should be larger than or equal to 0",
+		},
+		{
+			name: "nil targetMinReplicas and targetMaxReplicas when scaling FHPA",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					APIVersion: autoscalingv1alpha1.GroupVersion.String(),
+					Kind:       autoscalingv1alpha1.FederatedHPAKind,
+					Name:       "bar",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:           "bar",
+						Schedule:       "0 0 13 * 1",
+						TargetReplicas: pointer.Int32(-1),
+					},
+				},
+			},
+			expectedErr: "targetMinReplicas and targetMaxReplicas cannot be nil at the same time if you want to scale FederatedHPA",
+		},
+		{
+			name: "targetMinReplicas is less than 0 when scaling FHPA",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					APIVersion: autoscalingv1alpha1.GroupVersion.String(),
+					Kind:       autoscalingv1alpha1.FederatedHPAKind,
+					Name:       "bar",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:              "bar",
+						Schedule:          "0 0 13 * 1",
+						TargetMinReplicas: pointer.Int32(-1),
+						TargetReplicas:    pointer.Int32(1),
+					},
+				},
+			},
+			expectedErr: "targetMinReplicas should be larger than 0",
+		},
+		{
+			name: "targetMaxReplicas is less than 0 when scaling FHPA",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					APIVersion: autoscalingv1alpha1.GroupVersion.String(),
+					Kind:       autoscalingv1alpha1.FederatedHPAKind,
+					Name:       "bar",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:              "bar",
+						Schedule:          "0 0 13 * 1",
+						TargetMaxReplicas: pointer.Int32(-1),
+						TargetReplicas:    pointer.Int32(1),
+					},
+				},
+			},
+			expectedErr: "targetMaxReplicas should be larger than 0",
+		},
+		{
+			name: "targetMaxReplicas is less than targetMinReplicas when scaling FHPA",
+			spec: &autoscalingv1alpha1.CronFederatedHPASpec{
+				ScaleTargetRef: autoscalingv2.CrossVersionObjectReference{
+					APIVersion: autoscalingv1alpha1.GroupVersion.String(),
+					Kind:       autoscalingv1alpha1.FederatedHPAKind,
+					Name:       "bar",
+				},
+				Rules: []autoscalingv1alpha1.CronFederatedHPARule{
+					{
+						Name:              "bar",
+						Schedule:          "0 0 13 * 1",
+						TargetMinReplicas: pointer.Int32(3),
+						TargetMaxReplicas: pointer.Int32(1),
+						TargetReplicas:    pointer.Int32(1),
+					},
+				},
+			},
+			expectedErr: "targetMaxReplicas should be larger than or equal to targetMinReplicas",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			errs := validateCronFederatedHPASpec(tt.spec, specFld)
+			err := errs.ToAggregate()
+			if err != nil {
+				errStr := err.Error()
+				if tt.expectedErr == "" {
+					t.Errorf("expected no error:\n  but got:\n  %s", errStr)
+				} else if !strings.Contains(errStr, tt.expectedErr) {
+					t.Errorf("expected to contain:\n  %s\ngot:\n  %s", tt.expectedErr, errStr)
+				}
+			} else {
+				if tt.expectedErr != "" {
+					t.Errorf("unexpected no error, expected to contain:\n  %s", tt.expectedErr)
+				}
+			}
+		})
+	}
+}