Fixed occasional errors with clusteraffinities

[XiShanYongYe-Chang]

What type of PR is this?

/kind flake

What this PR does / why we need it:

In the karmada-scheduler, the patch is used to update the rb status. Before the update, deep copy is performed on the rb. As a result, the subsequent rb objects are still the old values, and patch errors may occur.

So I modified this to keep the rb object up-to-date after the update to avoid affecting subsequent patch operations.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[codecov-commenter]

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (d43f22f) 51.78% compared to head (7825b04) 51.79%.

Files	Patch %	Lines
pkg/scheduler/scheduler.go	30.00%	28 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3518   +/-   ##
=======================================
  Coverage   51.78%   51.79%           
=======================================
  Files         243      243           
  Lines       24112    24120    +8     
=======================================
+ Hits        12486    12492    +6     
- Misses      10945    10948    +3     
+ Partials      681      680    -1     

Flag	Coverage Δ
unittests	51.79% <30.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[XiShanYongYe-Chang]

/cc @chaunceyjiang @RainbowMango

[chaunceyjiang]

Have you already found the root cause of this issue? /cc @XiShanYongYe-Chang

[XiShanYongYe-Chang]

Have you already found the root cause of this issue?

I caught an error log earlier, but I seem to have lost it. When checking logs, it is found that the scheduler updates the status of the rb to an incorrect old status during subsequent update. As a result, the eventhandler does not meet the conditions during check.

[RainbowMango]

another one from master:
https://github.com/karmada-io/karmada/actions/runs/5507318884/jobs/10037376281

[RainbowMango]

another failing case on master:
https://github.com/karmada-io/karmada/actions/runs/5610539390/job/15200537208

[XiShanYongYe-Chang]

This PR is ready, can you help review it?
/cc @RainbowMango @chaunceyjiang

[RainbowMango]

/assign

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from rainbowmango after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[XiShanYongYe-Chang]

/hold
Let me think about whether it is possible to consolidate the update operations as much as possible, in order to reduce conflicts and impacts caused by multiple updates in different places.

[XiShanYongYe-Chang]

I think using the patch method in #4094 should be able to solve the current issue with patch errors. What do you think? @chaunceyjiang

[XiShanYongYe-Chang]

It seems that the issue has not occurs for a long time.
/close

[karmada-bot]

@XiShanYongYe-Chang: Closed this PR.

In response to this:

It seems that the issue has not occurs for a long time.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.