Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/webhook: unit test Interpreter #5542

Merged
merged 1 commit into from
Oct 9, 2024
Merged

pkg/webhook: unit test Interpreter #5542

merged 1 commit into from
Oct 9, 2024

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we introduce unit tests for the Interpreter webhook across Decoder, HTTP, Injection, Response, and Webhook components.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 13, 2024
@mohamedawnallah mohamedawnallah mentioned this pull request Sep 13, 2024
Open
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.64%. Comparing base (2e60a6e) to head (c571cfb).
Report is 88 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5542      +/-   ##
==========================================
+ Coverage   34.14%   35.64%   +1.50%     
==========================================
  Files         643      645       +2     
  Lines       44509    44994     +485     
==========================================
+ Hits        15197    16038     +841     
+ Misses      28156    27705     -451     
- Partials     1156     1251      +95
Flag Coverage Δ
unittests 35.64% <100.00%> (+1.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

/assign

@XiShanYongYe-Chang
Copy link
Member

Hi @mohamedawnallah, can you help squash the commits into one?

@mohamedawnallah
Copy link
Contributor Author

Closing and reopening some flaky e2e test cases...

@mohamedawnallah
Copy link
Contributor Author

Hi @XiShanYongYe-Chang, I've squashed the commits into single one and all tests passed :)

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mohamedawnallah can you try to rewrite it as table drive?

pkg/webhook/interpreter/http_test.go Outdated Show resolved Hide resolved
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 5, 2024
@mohamedawnallah
Copy link
Contributor Author

Thanks @XiShanYongYe-Chang for the feedback regards using the table driven method! It looks much cleaner now. I will ask for review when the GitHub CI tests finish :)

@mohamedawnallah
pkg/webhook: test Interpreter
c571cfb 
In this commit, we introduce unit tests for the `Interpreter` webhook
across `Decoder`, `HTTP`, `Injection`, `Response`, and `Webhook` components.

Signed-off-by: Mohamed Awnallah <[email protected]>
@XiShanYongYe-Chang
Copy link
Member

Thanks a lot~ Good job.
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
@karmada-bot karmada-bot merged commit 376d203 into karmada-io:master Oct 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@jwcesign jwcesign Awaiting requested review from jwcesign

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohamedawnallah @codecov-commenter @XiShanYongYe-Chang @karmada-bot