Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg/tasks/init: unit test wait #5657

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Oct 9, 2024

Description

In this commit, we unit test wait init task on waiting for Karmada APIServer and Karmada Control Plane components.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.
Depends on #5624.

Does this PR introduce a user-facing change?:

NONE

In this commit, we unit test wait init task on waiting for Karmada APIServer
and Karmada Control Plane components.

Signed-off-by: Mohamed Awnallah <[email protected]>
@mohamedawnallah
Copy link
Contributor Author

Rebased after merging #5624. I'll ask for a review once the GitHub CI tests are complete. :)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.89%. Comparing base (201409c) to head (04d073c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5657      +/-   ##
==========================================
+ Coverage   37.75%   37.89%   +0.13%     
==========================================
  Files         649      649              
  Lines       45133    45133              
==========================================
+ Hits        17042    17105      +63     
+ Misses      26795    26730      -65     
- Partials     1296     1298       +2     
Flag Coverage Δ
unittests 37.89% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah
Copy link
Contributor Author

cc @XiShanYongYe-Chang

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@karmada-bot karmada-bot merged commit 11b3175 into karmada-io:master Oct 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants