Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file line terminators to LF #5670

Merged

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR doesn't change anything but adjusts the file line terminators from CRLF to LF.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Find files with CRLF line terminators:

# find /root/go/src/github.com/karmada-io/karmada/ -type f -exec file {} \; | grep -v "vendor" | grep CRLF
/root/go/src/github.com/karmada-io/karmada/.github/workflows/ci-image-scanning.yaml: ASCII text, with CRLF line terminators
/root/go/src/github.com/karmada-io/karmada/pkg/resourceinterpreter/default/thirdparty/resourcecustomizations/apps.kruise.io/v1alpha1/DaemonSet/customizations.yaml: ASCII text, with CRLF line terminators
/root/go/src/github.com/karmada-io/karmada/pkg/resourceinterpreter/default/thirdparty/resourcecustomizations/kyverno.io/v1/Policy/testdata/desired-policy.yaml: ASCII text, with CRLF line terminators
/root/go/src/github.com/karmada-io/karmada/pkg/resourceinterpreter/default/thirdparty/resourcecustomizations/kyverno.io/v1/Policy/testdata/status-file.yaml: ASCII text, with CRLF line terminators
/root/go/src/github.com/karmada-io/karmada/pkg/resourceinterpreter/default/thirdparty/resourcecustomizations/kyverno.io/v1/Policy/testdata/observed-policy.yaml: ASCII text, with CRLF line terminators

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 11, 2024
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 11, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.57%. Comparing base (5dd4ab8) to head (e9e3c62).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5670      +/-   ##
==========================================
+ Coverage   36.54%   36.57%   +0.02%     
==========================================
  Files         648      648              
  Lines       45079    45079              
==========================================
+ Hits        16473    16486      +13     
+ Misses      27363    27350      -13     
  Partials     1243     1243              
Flag Coverage Δ
unittests 36.57% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member Author

cc file owner @yike21 @zhzhuang-zju

@yike21
Copy link
Member

yike21 commented Oct 11, 2024

/lgtm
Thanks! :)

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
@zhzhuang-zju
Copy link
Contributor

/lgtm

@RainbowMango
Copy link
Member Author

cc @chaunceyjiang @XiShanYongYe-Chang for approval.

@chaunceyjiang
Copy link
Member

/lgtm

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@karmada-bot karmada-bot merged commit 2bebd4c into karmada-io:master Oct 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants