Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added second part of unit tests for pkg/scheduler #5681

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR significantly enhances the unit tests for the scheduler package and is the second part of unit tests for it. The improvements aim to increase code reliability, maintainability, and test coverage for various scheduler functions.

Note:
The CI tests might fail because the imports needed for tests are included in the first part of unit tests for scheduler module.

Modifications:
pkg/scheduler/scheduler_test.go

Key Improvements:

  1. Added tests for scheduleClusterResourceBindingWithClusterAffinity and scheduleClusterResourceBindingWithClusterAffinities.
  2. Added tests for the worker functionality and scheduleNext method.
  3. Added tests for the placementChanged function.
  4. Added new test cases for the TestCreateScheduler

Test Coverage:
pkg/scheduler/scheduler_test.go: 29.71% to 66.90%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 12, 2024
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 12, 2024
@anujagrawal699 anujagrawal699 force-pushed the part2-addedTests-pkg/scheduler/scheduler.go branch from 6c06991 to b9ea99c Compare October 15, 2024 06:47
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 15, 2024
@anujagrawal699 anujagrawal699 force-pushed the part2-addedTests-pkg/scheduler/scheduler.go branch from b9ea99c to 88b39c0 Compare October 15, 2024 06:55
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.63%. Comparing base (bf771c7) to head (261cbdb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5681      +/-   ##
==========================================
+ Coverage   38.50%   38.63%   +0.13%     
==========================================
  Files         649      649              
  Lines       45133    45133              
==========================================
+ Hits        17378    17438      +60     
+ Misses      26421    26363      -58     
+ Partials     1334     1332       -2     
Flag Coverage Δ
unittests 38.63% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anujagrawal699
Copy link
Contributor Author

@XiShanYongYe-Chang Please take a look.

@XiShanYongYe-Chang
Copy link
Member

/assign

Signed-off-by: Anuj Agrawal <[email protected]>

Added second part of unit tests for pkg/scheduler

Signed-off-by: Anuj Agrawal <[email protected]>

Added second part of unit tests for pkg/scheduler

Signed-off-by: Anuj Agrawal <[email protected]>
@anujagrawal699 anujagrawal699 force-pushed the part2-addedTests-pkg/scheduler/scheduler.go branch from 88b39c0 to 261cbdb Compare October 15, 2024 09:30
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@karmada-bot karmada-bot merged commit 4db8867 into karmada-io:master Oct 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants