fixed: https://github.com/kartik-v/yii2-export/issues/378 #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed: PHP Compile Error – yii\base\ErrorException Declaration of kartik\export\ExportWriterPdf::createExternalWriterInstance($config = []) must be compatible with PhpOffice\PhpSpreadsheet\Writer\Pdf\Mpdf::createExternalWriterInstance(array $config): Mpdf\Mpdf Test in PHP 8,1
…tch-1 Update ExportWriterPdf.php
|
Thanks for the fix. Any chance this can be merged and released ? |
|
if this can't be merged for some reason, another solution that doesn't involve code changes would be to update the composer.json to read |
|
@kartik-v from my point of view, you can merge this. |
|
Thanks this will work in latest PHP releases probably > 8 - will need to update the BC breaking dependencies for older PHP versions. Will check a bit on this and probaby create a BC breaking version supporting only newer PHP releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This pull request includes a
PHP Compile Error – yii\base\ErrorException
Declaration of kartik\export\ExportWriterPdf::createExternalWriterInstance($config = []) must be compatible with PhpOffice\PhpSpreadsheet\Writer\Pdf\Mpdf::createExternalWriterInstance(array $config): Mpdf\Mpdf
Related Issues
If this is related to an existing ticket, include a link to it as well.
#378