ci/openshift-ci: Tweak test.sh to run with kubernetes #5799
Conversation
| @@ -40,13 +40,29 @@ hello_msg='Hello World' | |||
| oc exec ${pod} -- sh -c "echo $hello_msg > $hello_file" | |||
|
|
|||
| info "Creating the service and route" | |||
| oc apply -f ${script_dir}/smoke/service.yaml | |||
| sleep 60 | |||
| if oc apply -f ${script_dir}/smoke/service.yaml; then | |||
There was a problem hiding this comment.
The service API (https://kubernetes.io/docs/concepts/services-networking/service/) should work with kcli too. Maybe there is a firewall blocking the port 80 on the VM?
There was a problem hiding this comment.
Services are supported, but routes are not. We can use ingress, but that one requires ingress controller, so using another pod seems simpler for the purpose of pod execution test.
There was a problem hiding this comment.
OK I found another way using service of type "NodePort", let me know which way you prefer.
|
@ldoktor missing the |
|
Squashed and rebased, no code changes. (PS: I prefer the 2 pod solution, but anything works for me :D) |
Plain kubernetes do not support routes and projects. Let's modify the deploy scripts to use generic alternatives to simplify local development. Fixes: kata-containers#5803 Signed-off-by: Lukáš Doktor <[email protected]>
the 10s sleep-time seems quite long and checking more often doen't waste resources extensively. Signed-off-by: Lukáš Doktor <[email protected]>
the hardcoded 60s wait is often unnecessarily too long and recently we added a busy-loop using "curl --retry". Let's leverage that and increase the deadline to 60s. Signed-off-by: Lukáš Doktor <[email protected]>
|
Rebased on top of master, fixed the styling issues found by @gkurz and added 2 (optional) commits to include the unrelated changes. Let me know if I should remove them but they should slightly speedup the prep steps. |
|
/test |
|
/test-s390x-main |
|
/retest-s390x-main |
|
/retest |
Plain kubernetes do not support services and such, let's modify our test.sh (and related) to allow deploying and checking kata there, which might help testing things locally with kcli.