This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
ci/openshift-ci: Use loop instead of curl --retry-all-errors #5806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wainersm
reviewed
Jan 22, 2024
.ci/openshift-ci/run_smoke_test.sh
Outdated
| @@ -56,7 +56,11 @@ else | |||
| port=$(oc get service/http-server-service -o jsonpath='{.spec.ports[0].nodePort}') | |||
| fi | |||
|
|
|||
| curl "${host}:${port}${hello_file}" -s -o hello_msg.txt --retry 60 --retry-delay 1 --retry-all-errors | |||
| rm -f hello_msg.txt | |||
| for i in $(seq 60); do | |||
There was a problem hiding this comment.
hi @ldoktor , good catch.
One suggestion is to use the waitForProcess (e.g. waitForProcess $wait_time $sleep_time "$cmd") utility.
|
Changes:
|
wainersm
approved these changes
Jan 22, 2024
|
@beraldoleal mind to review this one? |
The --retry-all-errors argument is not supported on the CI runners, use a busy loop instead. Fixes: kata-containers#5802 Signed-off-by: Lukáš Doktor <[email protected]>
To avoid using pre-existing file ensure it's not present by deleting it. Signed-off-by: Lukáš Doktor <[email protected]>
|
Changes: Added the fixes to commit a message |
|
/test |
|
Changes: Removed the controversial commit that treats |
gkurz
approved these changes
Jan 23, 2024
|
/test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --retry-all-errors argument is not supported on the CI runners, use a busy loop instead.