Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update image version #2919

Closed
wants to merge 1 commit into from
Closed

📖 Update image version #2919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/concepts/registering-kubernetes-clusters-using-syncer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ To register a Kubernetes cluster with kcp, you have to install a special compone
kubectl kcp workload sync <synctarget name> --syncer-image <image name> -o syncer.yaml
```

Where `<image name>` [one of the syncer images](https://github.com/kcp-dev/kcp/pkgs/container/kcp%2Fsyncer) for your corresponding KCP release (e.g. `ghcr.io/kcp-dev/kcp/syncer:v0.7.5`).
Where `<image name>` [one of the syncer images](https://github.com/kcp-dev/kcp/pkgs/container/kcp%2Fsyncer) for your corresponding KCP release (e.g. `ghcr.io/kcp-dev/kcp/syncer:v0.11.0`).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image also has a main tag, I wonder if we should use that for the main version of the docs?

To avoid this getting outdated again, we could say something like "... for your corresponding KCP release, or main for the development version (e.g. ghcr.io/kcp-dev/kcp/syncer:main )."


1. Apply the manifest to the p-cluster:

Expand Down
4 changes: 2 additions & 2 deletions docs/content/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ In this recipe we use the root workspace to hold the description of the workload
Run the following command to tell kcp about the `kind` cluster (replace the syncer image tag as needed; CI now puts built images in https://github.com/orgs/kcp-dev/packages):

```shell
$ kubectl kcp workload sync kind --syncer-image ghcr.io/kcp-dev/kcp/syncer:v0.10.0 -o syncer-kind-main.yaml
$ kubectl kcp workload sync kind --syncer-image ghcr.io/kcp-dev/kcp/syncer:v0.11.0 -o syncer-kind-main.yaml
Creating synctarget "kind"
Creating service account "kcp-syncer-kind-25coemaz"
Creating cluster role "kcp-syncer-kind-25coemaz" to give service account "kcp-syncer-kind-25coemaz"
Expand Down Expand Up @@ -103,7 +103,7 @@ deployment.apps/kcp-syncer-kind-25coemaz created

### Bind to workload APIs and create default placement

If you are running kcp version v0.10.0 or higher, you will need to run the following commmand (continuing in the `root` workspace)
If you are running kcp version v0.11.0 or higher, you will need to run the following commmand (continuing in the `root` workspace)
to create a binding to the workload APIs export and a default placement for your physical cluster:

```shell
Expand Down