Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support for Azure Workload Identity in Cosmos DB External Scaler #652

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karpikpl
Copy link

Added support for Azure Workload Identity to Azure Cosmos DB external scaler

Changes:

  • label azure.workload.identity/use: "true"
  • option to provide a service account

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

It looks like Readme is auto-generated based on values file. I believe PR to KEDA core is not needed.

@karpikpl karpikpl requested a review from a team as a code owner June 11, 2024 01:59
@karpikpl
Copy link
Author

After additional review of the docs - I'm not 100% sure if this PR is needed.
Can someone confirm I can use TriggerAuthentication (and workload identity) with external-scaler-azure-cosmos-db ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant