Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The parameter of "InitialCooldownPeriod" is incorrect in reference module #1486

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

The parameter of "InitialCooldownPeriod" is incorrect in reference module #1486

wants to merge 2 commits into from
+9 −9

Conversation

IEnglishBad
Copy link

Checklist

  • content/docs/2.14/reference/scaledobject-spec.md
  • content/docs/2.15/reference/scaledobject-spec.md
  • content/docs/2.16/reference/scaledobject-spec.md

Fixes

  1. The value of "InitialCooldownPeriod" in yaml should be "initialCooldownPeriod"

Signed-off-by: YuHaoXiang [email protected]

@IEnglishBad IEnglishBad requested a review from a team as a code owner October 16, 2024 05:11
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit c68e515
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6719b4d8f823fb0008f467f6
😎 Deploy Preview https://deploy-preview-1486--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

wozniakjan
wozniakjan approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan
Copy link
Member

wozniakjan commented Oct 25, 2024 •
edited
Loading

@IEnglishBad can you please rebase the commits with --signoff? the project requires all commits to be signed.

https://github.com/kedacore/keda-docs/pull/1486/checks?check_run_id=31984461154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IEnglishBad @wozniakjan