Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KEDA-specific annotation name for last config #201

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Aug 1, 2023

Manifestival > v0.7.2 has the ability to use an app-specific annotation
name so that our changes don't conflict with kubectl-applied changes.

Deps updates:

  go get github.com/manifestival/manifestival@f20c69532c27cff6358cd681be7a477b8c897d54
  go get k8s.io/[email protected]
  go mod tidy

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Manifestival > v0.7.2 has the ability to use an app-specific annotation
name so that our changes don't conflict with kubectl-applied changes.

Deps updates:
  go get github.com/manifestival/manifestival@f20c69532c27cff6358cd681be7a477b8c897d54
  go get k8s.io/[email protected]
  go mod tidy

Signed-off-by: Joel Smith <[email protected]>
@joelsmith
Copy link
Contributor Author

@zroubalik when you have a moment, please take a look at this. I made the change to fix an issue my customer is running into where when ArgoCD is used to add labels to objects which are also managed by the OLM operator, they revert each other's changes on each reconcile iteration.

By using our own annotation name for the last-applied-config field, we won't try to manage fields which were added by other processes which happen to be using kubectl to add labels or annotations to our objects.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 019c746 into kedacore:main Aug 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants