Fix hack/relprep.sh script to match KEDA repo #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joel Smith <[email protected]>
Signed-off-by: Joel Smith <[email protected]>
|
Makes sense -- if we ever need to skew on those deps for a good reason we still can, we'll just be more explicit about it. Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the relprep script assumed we always wanted the latest go toolchain, but that might not be the case for point releases. Now we will explicitly match what KEDA used for a given release.
Same goes for
sigs.k8s.io/controller-runtime,sigs.k8s.io/controller-runtime/tools/setup-envtestandsigs.k8s.io/controller-tools.Checklist