Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 2.14.1 #239

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Prepare release 2.14.1 #239

merged 1 commit into from
Aug 2, 2024

Conversation

jkyros
Copy link
Contributor

@jkyros jkyros commented Aug 2, 2024

  • This also adds a RESTRICTED variable to the Makfile and relprep instructions to allow for more successful testing against clusters with restricted namespaces, e.g. make VERSION=2.14.1 IMAGE_REGISTRY=quay.io IMAGE_REPO=jkyros RESTRICTED=true deploy-olm-testing , which will make sure the --security-context-config restricted argument gets supplied when running the bundle.
  • Additionally, the envtest 1.29.4 assets cause the functionality tests to panic:
  Unexpected error:
      <*fmt.wrapError | 0xc000342920>: 
      unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH
      {
          msg: "unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: \"etcd\": executable file not found in $PATH",
          err: <*fmt.wrapError | 0xc000342900>{
              msg: "failed to start the controlplane. retried 5 times: exec: \"etcd\": executable file not found in $PATH",
              err: <*exec.Error | 0xc0003428c0>{
                  Name: "etcd",
                  Err: <*errors.errorString | 0x2af4db0>{
                      s: "executable file not found in $PATH",
                  },
              },
          },
      }
  • I moved the envtest assets varialbe back to 1.29.3 and it works. 1.29 still works also, like it was before we started updating that with the script.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Copy link
Contributor

@joelsmith joelsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that my instructions weren't complete. Unfortunately the deploy-olm-testing changes bundle manifests that we commit, so it probably would have been better if we had a step between 4 and 5 in relprep.sh that said "Don't add/commit the new changes to the bundle resulting from deploy-olm-testing runs" or something like that. We only want the stuff up to step 1 to go into the commit.

You should be able to revert almost everything by running:

make bundle

(You'll also need to lop off all but the top two lines of config/manager/kustomization.yaml)

bundle/manifests/eventing.keda.sh_cloudeventsources.yaml Outdated Show resolved Hide resolved
bundle/manifests/keda.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/keda.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/keda.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/keda.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/keda.sh_scaledjobs.yaml Outdated Show resolved Hide resolved
config/default/kustomization.yaml Outdated Show resolved Hide resolved
bundle/manifests/keda.sh_triggerauthentications.yaml Outdated Show resolved Hide resolved
bundle/manifests/keda.sh_scaledobjects.yaml Outdated Show resolved Hide resolved
config/manager/kustomization.yaml Outdated Show resolved Hide resolved
- This also adds a RESTRICTED variable to the Makefile and relprep
  instructions to allow for more successful testing against clusters
  with restricted namespaces
- The envtest 1.29.4 assets are problematic and panic the functionality
  tests, but the 1.29.3 assets work properly. I don't know root cause,
  I just know that 1.29.4 doesn't work.

Signed-off-by: John Kyros <[email protected]>
Copy link

github-actions bot commented Aug 2, 2024

Diff 2.14.1/manifests/keda.sh_scaledjobs.yaml & 2.14.0/manifests/keda.sh_scaledjobs.yaml

9c9
<     app.kubernetes.io/version: 2.14.0
---
>     app.kubernetes.io/version: 2.14.1

Copy link

github-actions bot commented Aug 2, 2024

Diff 2.14.1/manifests/keda.sh_triggerauthentications.yaml & 2.14.0/manifests/keda.sh_triggerauthentications.yaml

9c9
<     app.kubernetes.io/version: 2.14.0
---
>     app.kubernetes.io/version: 2.14.1

Copy link

github-actions bot commented Aug 2, 2024

Diff 2.14.1/manifests/eventing.keda.sh_cloudeventsources.yaml & 2.14.0/manifests/eventing.keda.sh_cloudeventsources.yaml

9c9
<     app.kubernetes.io/version: 2.14.0
---
>     app.kubernetes.io/version: 2.14.1

Copy link

github-actions bot commented Aug 2, 2024

Diff 2.14.1/manifests/keda.v2.14.1.clusterserviceversion.yaml & 2.14.0/manifests/keda.v2.14.0.clusterserviceversion.yaml

118c118
<     containerImage: ghcr.io/kedacore/keda-olm-operator:2.14.0
---
>     containerImage: ghcr.io/kedacore/keda-olm-operator:2.14.1
126c126
<   name: keda.v2.14.0
---
>   name: keda.v2.14.1
604c604
<                 image: ghcr.io/kedacore/keda-olm-operator:2.14.0
---
>                 image: ghcr.io/kedacore/keda-olm-operator:2.14.1
676c676
<   replaces: keda.v2.13.1
---
>   replaces: keda.v2.14.0
678c678
<   version: 2.14.0
---
>   version: 2.14.1

Copy link

github-actions bot commented Aug 2, 2024

Diff 2.14.1/manifests/keda.sh_clustertriggerauthentications.yaml & 2.14.0/manifests/keda.sh_clustertriggerauthentications.yaml

9c9
<     app.kubernetes.io/version: 2.14.0
---
>     app.kubernetes.io/version: 2.14.1

Copy link

github-actions bot commented Aug 2, 2024

Diff output of 2.14.1/manifests/keda.sh_kedacontrollers.yaml is too large - character limit 65536 exceeded for github comment

Copy link

github-actions bot commented Aug 2, 2024

Diff 2.14.1/manifests/keda.sh_scaledobjects.yaml & 2.14.0/manifests/keda.sh_scaledobjects.yaml

9c9
<     app.kubernetes.io/version: 2.14.0
---
>     app.kubernetes.io/version: 2.14.1

@joelsmith joelsmith merged commit 35181ac into kedacore:main Aug 2, 2024
16 checks passed
@joelsmith joelsmith mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants