-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Provide validation for identityId with Azure pod identity & Azure AD …
…Workload Identity in TriggerAuthentication (#4696) Co-authored-by: Tom Kerkhove <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]>
- Loading branch information
3 people
authored
Aug 29, 2023
1 parent
4218b0d
commit 046d2bb
Showing
26 changed files
with
740 additions
and
147 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| /* | ||
| Copyright 2023 The KEDA Authors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "context" | ||
| "crypto/tls" | ||
| "fmt" | ||
| "net" | ||
| "path/filepath" | ||
| "testing" | ||
| "time" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| admissionv1beta1 "k8s.io/api/admission/v1beta1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| clientgoscheme "k8s.io/client-go/kubernetes/scheme" | ||
| "k8s.io/client-go/rest" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/envtest" | ||
| logf "sigs.k8s.io/controller-runtime/pkg/log" | ||
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | ||
| ) | ||
|
|
||
| // These tests use Ginkgo (BDD-style Go testing framework). Refer to | ||
| // http://onsi.github.io/ginkgo/ to learn more about Ginkgo. | ||
|
|
||
| var cfg *rest.Config | ||
| var k8sClient client.Client | ||
| var testEnv *envtest.Environment | ||
| var ctx context.Context | ||
| var cancel context.CancelFunc | ||
|
|
||
| const ( | ||
| workloadName = "deployment-name" | ||
| soName = "test-so" | ||
| ) | ||
|
|
||
| func TestAPIs(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
|
|
||
| RunSpecs(t, "Webhook Suite") | ||
| } | ||
|
|
||
| var _ = BeforeSuite(func() { | ||
| logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true))) | ||
|
|
||
| ctx, cancel = context.WithCancel(context.Background()) | ||
|
|
||
| By("bootstrapping test environment") | ||
| testEnv = &envtest.Environment{ | ||
| CRDDirectoryPaths: []string{filepath.Join("..", "..", "..", "config", "crd", "bases")}, | ||
| ErrorIfCRDPathMissing: false, | ||
| WebhookInstallOptions: envtest.WebhookInstallOptions{ | ||
| Paths: []string{filepath.Join("..", "..", "..", "config", "webhooks")}, | ||
| }, | ||
| } | ||
| var err error | ||
| // cfg is defined in this file globally. | ||
| done := make(chan interface{}) | ||
| go func() { | ||
| defer GinkgoRecover() | ||
| cfg, err = testEnv.Start() | ||
| close(done) | ||
| }() | ||
| Eventually(done).WithTimeout(time.Minute).Should(BeClosed()) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(cfg).NotTo(BeNil()) | ||
|
|
||
| scheme := runtime.NewScheme() | ||
| err = AddToScheme(scheme) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| err = clientgoscheme.AddToScheme(scheme) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| err = admissionv1beta1.AddToScheme(scheme) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| //+kubebuilder:scaffold:scheme | ||
|
|
||
| k8sClient, err = client.New(cfg, client.Options{Scheme: scheme}) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(k8sClient).NotTo(BeNil()) | ||
|
|
||
| // start webhook server using Manager | ||
| webhookInstallOptions := &testEnv.WebhookInstallOptions | ||
| mgr, err := ctrl.NewManager(cfg, ctrl.Options{ | ||
| Scheme: scheme, | ||
| Host: webhookInstallOptions.LocalServingHost, | ||
| Port: webhookInstallOptions.LocalServingPort, | ||
| CertDir: webhookInstallOptions.LocalServingCertDir, | ||
| LeaderElection: false, | ||
| MetricsBindAddress: "0", | ||
| }) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| err = (&ScaledObject{}).SetupWebhookWithManager(mgr) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| err = (&TriggerAuthentication{}).SetupWebhookWithManager(mgr) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| err = (&ClusterTriggerAuthentication{}).SetupWebhookWithManager(mgr) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| //+kubebuilder:scaffold:webhook | ||
|
|
||
| go func() { | ||
| defer GinkgoRecover() | ||
| err = mgr.Start(ctx) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| }() | ||
|
|
||
| // wait for the webhook server to get ready | ||
| dialer := &net.Dialer{Timeout: time.Second} | ||
| addrPort := fmt.Sprintf("%s:%d", webhookInstallOptions.LocalServingHost, webhookInstallOptions.LocalServingPort) | ||
| Eventually(func() error { | ||
| conn, err := tls.DialWithDialer(dialer, "tcp", addrPort, &tls.Config{InsecureSkipVerify: true}) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| conn.Close() | ||
| return nil | ||
| }).Should(Succeed()) | ||
|
|
||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.