Skip to content

Commit

Permalink
ScaledJob: Support metadata annotations for ephemeral volume claims
Browse files Browse the repository at this point in the history
Signed-off-by: Dimitri Pertin <[email protected]>
  • Loading branch information
dpertin committed Oct 22, 2024
1 parent d849c75 commit 0a2a958
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ Here is an overview of all new **experimental** features:
- **AWS Secret Manager**: Pod identity overrides are honored ([#6195](https://github.com/kedacore/keda/issues/6195))
- **Azure Event Hub Scaler**: Checkpointer errors are correctly handled ([#6084](https://github.com/kedacore/keda/issues/6084))
- **Metrics API Scaler**: Prometheus metrics can have multiple labels ([#6077](https://github.com/kedacore/keda/issues/6077))
- **ScaledJob CRD**: Support metadata annotations for ephemeral's volume claims ([6254](https://github.com/kedacore/keda/issues/6254))

### Deprecations

Expand Down
4 changes: 4 additions & 0 deletions config/crd/patches/scaledjob_patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/jobTargetRef/properties/template/properties/metadata/x-kubernetes-preserve-unknown-fields
value: true

- op: add
path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/jobTargetRef/properties/template/properties/spec/properties/volumes/items/properties/ephemeral/properties/volumeClaimTemplate/properties/metadata/x-kubernetes-preserve-unknown-fields
value: true

## triggers are shared by ScaledObjects and ScaledJobs and therefore generated for both, including all properties.
## since the metricType property is only supported for ScaledObject, removing it from the generated ScaledJob CRD
- op: remove
Expand Down

0 comments on commit 0a2a958

Please sign in to comment.