Add Username and Password for Selenium Grid Basic Auth #6142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vei0vis <[email protected]>
Signed-off-by: Vei0vis <[email protected]>
Merged
1 task
zroubalik
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Looking good.
@JorTurFer WDYT do we need e2e test for this? I am not sure.
JorTurFer
approved these changes
Oct 6, 2024
|
/run-e2e selenium |
VietND96
pushed a commit
to NDViet/keda
that referenced
this pull request
Oct 7, 2024
* Add Username and Password for Selenium Grid Basic Auth Signed-off-by: Vei0vis <[email protected]> * Update CHANGELOG.md Signed-off-by: Vei0vis <[email protected]> --------- Signed-off-by: Vei0vis <[email protected]> Co-authored-by: Vei0vis <[email protected]> Signed-off-by: Viet Nguyen Duc <[email protected]>
VietND96
pushed a commit
to NDViet/keda
that referenced
this pull request
Oct 7, 2024
* Add Username and Password for Selenium Grid Basic Auth Signed-off-by: Vei0vis <[email protected]> * Update CHANGELOG.md Signed-off-by: Vei0vis <[email protected]> --------- Signed-off-by: Vei0vis <[email protected]> Co-authored-by: Vei0vis <[email protected]> Signed-off-by: Viet Nguyen Duc <[email protected]>
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Oct 7, 2024
* Add Username and Password for Selenium Grid Basic Auth Signed-off-by: Vei0vis <[email protected]> * Update CHANGELOG.md Signed-off-by: Vei0vis <[email protected]> --------- Signed-off-by: Vei0vis <[email protected]> Co-authored-by: Vei0vis <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 21, 2024
* Add Username and Password for Selenium Grid Basic Auth Signed-off-by: Vei0vis <[email protected]> * Update CHANGELOG.md Signed-off-by: Vei0vis <[email protected]> --------- Signed-off-by: Vei0vis <[email protected]> Co-authored-by: Vei0vis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure Basic Authentication for the Selenium Grid Scaler by setting the username and password directly, instead of embedding them in the URL. This enhances security and flexibility when configuring authentication for the scaler.
Checklist
Fixes #
Relates to #