Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support username and password for etcd #6199

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Support username and password for etcd #6199

merged 2 commits into from
Oct 21, 2024

Conversation

dovics
Copy link
Contributor

@dovics dovics commented Sep 30, 2024 •
edited
Loading

Provide a description of what has been changed

  • Refactor the etcd scaler to match the new metadata guidelines.
  • Add Support for Username and Password Authentication

Checklist

Relates to #5797

@dovics dovics requested a review from a team as a code owner September 30, 2024 15:43
@dovics dovics changed the title Refactor etcd scaler metadata Refactor etcd scaler config Sep 30, 2024
@n0rm4l-real
Copy link

Is it possible to add user / password based authentication here?

@dovics
Copy link
Contributor Author

dovics commented Oct 7, 2024

@n0rm4l-real Hi，I added username and password authentication support, can you take a look?

@JorTurFer JorTurFer changed the title Refactor etcd scaler config Support username and password for etcd Oct 16, 2024
@JorTurFer
Copy link
Member

PTAL @wozniakjan

@JorTurFer
Copy link
Member

@dovics , could you open a PR to add the values in docs?

@dovics dovics mentioned this pull request Oct 20, 2024
Merged
1 task
@wozniakjan
Copy link
Member

wozniakjan commented Oct 21, 2024 •
edited by github-actions bot
Loading

/run-e2e etcd
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan enabled auto-merge (squash) October 21, 2024 07:25
@wozniakjan
Copy link
Member

wozniakjan commented Oct 21, 2024 •
edited by github-actions bot
Loading

/run-e2e etcd
Update: You can check the progress here

@wozniakjan wozniakjan merged commit 1a49f5f into kedacore:main Oct 21, 2024
18 checks passed
@wozniakjan wozniakjan mentioned this pull request Oct 21, 2024
Open
59 tasks
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
@dovics @rickbrouwer
Support username and password for etcd (kedacore#6199)
774c747 
* Refactor etcd scaler metadata

Signed-off-by: wangrushen <[email protected]>

* feat: Add Support for etcd Username and Password Authentication

Signed-off-by: wangrushen <[email protected]>

---------

Signed-off-by: wangrushen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dovics @n0rm4l-real @JorTurFer @wozniakjan