Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show full triggers and authentications in status #6232

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Show full triggers and authentications in status #6232

wants to merge 16 commits into from

Conversation

SpiritZhou
Copy link
Contributor

Show full triggers and authentications in status

image

Checklist

Relates to # #6187 #1943

@SpiritZhou SpiritZhou requested a review from a team as a code owner October 11, 2024 07:31
JorTurFer
JorTurFer approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just 2 small updates inline.
PTAL @kedacore/keda-core-contributors

tests/internals/status_update/status_update_test.go Outdated Show resolved Hide resolved
tests/internals/status_update/status_update_test.go Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Oct 16, 2024 •
edited by github-actions bot
Loading

/run-e2e status_update_test
Update: You can check the progress here

SpiritZhou and others added 6 commits October 21, 2024 13:23
@SpiritZhou @wozniakjan
Update
9bcbe99 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @wozniakjan
Fix
10a20a8 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @wozniakjan
Fix
9600e2f 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @wozniakjan
Fix
d022250 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @JorTurFer @wozniakjan
Update tests/internals/status_update/status_update_test.go
a68611c 
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @JorTurFer @wozniakjan
Update tests/internals/status_update/status_update_test.go
146a0f7 
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
zroubalik
zroubalik reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, just some nits around naming.

apis/keda/v1alpha1/scaledjob_types.go Outdated Show resolved Hide resolved
apis/keda/v1alpha1/scaledjob_types.go Outdated Show resolved Hide resolved
apis/keda/v1alpha1/scaledobject_types.go Outdated Show resolved Hide resolved
apis/keda/v1alpha1/scaletriggers_types.go Outdated Show resolved Hide resolved
SpiritZhou and others added 10 commits October 24, 2024 10:46
@SpiritZhou @zroubalik
Update apis/keda/v1alpha1/scaledjob_types.go
b1c88b4 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @zroubalik
Update apis/keda/v1alpha1/scaledjob_types.go
3e4379b 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @zroubalik
Update apis/keda/v1alpha1/scaletriggers_types.go
2643f66 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Merge branch 'main' into spiritzhou/fulltriggername
f20078b 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
63e0a1e 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update "name" to "type"
786aeb8 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
90244d2 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
0b0a76e 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
e03c00f 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Merge branch 'main' into spiritzhou/fulltriggername
eae8ab5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpiritZhou @JorTurFer @zroubalik