-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show full triggers and authentications in status #6232
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just 2 small updates inline.
PTAL @kedacore/keda-core-contributors
/run-e2e status_update_test |
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: SpiritZhou <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: SpiritZhou <[email protected]>
ecf711d
to
146a0f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, just some nits around naming.
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: SpiritZhou <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: SpiritZhou <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Show full triggers and authentications in status
Checklist
Relates to # #6187 #1943