Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to not scale GitHub runner on default runner labels #6251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leevilehtonen
Copy link

Add new option to not scale GitHub runner on default runner labels

Checklist

Fixes #6127

Relates to (TODO: keda-docs)

Copy link

semgrep-app bot commented Oct 20, 2024

Semgrep found 3 context-todo findings:

Consider to use well-defined context

Ignore this finding from context-todo.

@leevilehtonen leevilehtonen marked this pull request as ready for review October 20, 2024 14:15
@leevilehtonen leevilehtonen requested a review from a team as a code owner October 20, 2024 14:15
@leevilehtonen
Copy link
Author

Selenium tests probably fixed in #6246

@JorTurFer
Copy link
Member

could you update docs as well?

@leevilehtonen
Copy link
Author

could you update docs as well?

I'll try to get them done this week

Copy link

semgrep-app bot commented Oct 26, 2024

Semgrep found 1 context-todo finding:

  • pkg/scalers/github_runner_scaler_test.go

Consider to use well-defined context

Ignore this finding from context-todo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github-runner-scaler always scales with default labels
2 participants