Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mongo scaler #6261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor mongo scaler #6261

wants to merge 1 commit into from

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Oct 22, 2024 •
edited
Loading

  • Refactor the scaler to match the new metadata guidelines.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 22, 2024 18:04
@rickbrouwer rickbrouwer marked this pull request as draft October 22, 2024 18:04
semgrep-app[bot]
semgrep-app bot reviewed Oct 22, 2024
View reviewed changes
pkg/scalers/mongo_scaler.go Outdated Show resolved Hide resolved
semgrep-app[bot]
semgrep-app bot reviewed Oct 22, 2024
View reviewed changes
pkg/scalers/mongo_scaler.go Outdated Show resolved Hide resolved
@wozniakjan wozniakjan mentioned this pull request Oct 23, 2024
Open
59 tasks
@rickbrouwer
Refactor mongo scaler
e93853c 
Signed-off-by: rickbrouwer <[email protected]>
@rickbrouwer rickbrouwer marked this pull request as ready for review October 23, 2024 07:28
@wozniakjan
Copy link
Member

wozniakjan commented Oct 23, 2024 •
edited by github-actions bot
Loading

/run-e2e mongo
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

@wozniakjan wozniakjan wozniakjan approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickbrouwer @wozniakjan