fix bug in ignoreopts and add back python versions 3.10 and 3.11 in m…

…atrix

Signed-off-by: tdhooghe <[email protected]>

.github/workflows/kedro-datasets.yml

@@ -22,7 +22,7 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-latest, windows-latest ]
-        python-version: [ "3.12" ]
+        python-version: [ "3.10", "3.11", "3.12" ]
     uses: ./.github/workflows/unit-tests.yml
     with:
       plugin: kedro-datasets

Makefile

@@ -52,17 +52,16 @@ test-no-spark: dataset-doctests-no-spark
 check-datasets-docs:
 	cd kedro-datasets && python -m sphinx -WETan -j auto -D language=en -b linkcheck -d _build/doctrees docs/source _build/linkcheck
 
+# omit Snowpark from python 3.12 testing, as it is not supported
+PYTHON_VERSION := $(shell python -c "import sys; print(f'{sys.version_info.major}.{sys.version_info.minor}')")
+ifeq ($(strip $(PYTHON_VERSION)),3.12)
+	IGNORE_OPTS := --ignore tests/tensorflow --ignore tests/snowflake/test_snowpark_dataset.py
+else
+	IGNORE_OPTS := --ignore tests/tensorflow
+endif
+
 # Run test_tensorflow_model_dataset separately, because these tests are flaky when run as part of the full test-suite
-# Omit Snowpark from python 3.12 testing, as it is not supported; while keeping coverage 100
 dataset-tests: dataset-doctests
-	PYTHON_VERSION=$(shell python3 -c "import sys; print(f'{sys.version_info.major}.{sys.version_info.minor}')")
-	IGNORE_OPTS=""
-	@if [ "$(PYTHON_VERSION)" = "3.12" ]; then \
-		IGNORE_OPTS="--ignore tests/tensorflow --ignore tests/snowflake/test_snowpark_dataset.py"; \
-	else \
-		IGNORE_OPTS="--ignore tests/tensorflow"; \
-	fi; \
-
 	cd kedro-datasets && pytest tests --cov-config pyproject.toml --numprocesses 4 --dist loadfile $(IGNORE_OPTS)
 	cd kedro-datasets && pytest tests/tensorflow/test_tensorflow_model_dataset.py --no-cov