Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Minor docs tweaks #266

Merged
merged 5 commits into from
Jul 28, 2023
Merged

docs: Minor docs tweaks #266

merged 5 commits into from
Jul 28, 2023

Conversation

sbrugman
Copy link
Contributor

Description

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

astrojuanlu
astrojuanlu requested changes Jul 12, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these small tweaks @sbrugman ! However I wouldn't touch the markup unless the rendering is broken, and there is one commend about the alt text of an image

kedro-docker/CONTRIBUTING.md Show resolved Hide resolved
kedro-telemetry/RELEASE.md Outdated Show resolved Hide resolved
kedro-telemetry/RELEASE.md Show resolved Hide resolved
@sbrugman
Minor docs tweaks
a533c02 
Signed-off-by: Simon Brugman <[email protected]>
@sbrugman sbrugman changed the title Minor docs tweaks docs: Minor docs tweaks Jul 12, 2023
@ankatiyar ankatiyar added the Community Issue/PR opened by the open-source community label Jul 13, 2023
astrojuanlu
astrojuanlu approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what, LGTM 😄

@astrojuanlu astrojuanlu enabled auto-merge (squash) July 26, 2023 17:22
merelcht
merelcht approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @sbrugman 👍

@merelcht merelcht disabled auto-merge July 28, 2023 14:21
@merelcht merelcht enabled auto-merge (squash) July 28, 2023 14:21
@merelcht merelcht merged commit fd4b2be into kedro-org:main Jul 28, 2023
29 checks passed
PtrBld pushed a commit to PtrBld/kedro-plugins that referenced this pull request Aug 27, 2023
@sbrugman @astrojuanlu
docs: Minor docs tweaks (kedro-org#266)
3b53085 
Minor docs tweaks

Signed-off-by: Simon Brugman <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merelcht merelcht merelcht approved these changes

@astrojuanlu astrojuanlu astrojuanlu approved these changes

Assignees
No one assigned
Labels
Community Issue/PR opened by the open-source community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbrugman @astrojuanlu @merelcht @ankatiyar