Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datasets): Improved compatibility, functionality and testing for SnowflakeTableDataset #881

Merged
merged 97 commits into from
Oct 28, 2024
Merged

feat(datasets): Improved compatibility, functionality and testing for SnowflakeTableDataset #881

merged 97 commits into from
Oct 28, 2024

Commits on Oct 21, 2024

  1. check and convert pd df to snowflake df 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2305c3d View commit details
    Browse the repository at this point in the history

  2. add tests 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    07ef67b View commit details
    Browse the repository at this point in the history

  3. revert import to previous state 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    04928ba View commit details
    Browse the repository at this point in the history

  4. relax snowpark version 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    77551d6 View commit details
    Browse the repository at this point in the history

  5. revert pyproject.toml 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fbb3374 View commit details
    Browse the repository at this point in the history

  6. bump snowpark version 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fb621ae View commit details
    Browse the repository at this point in the history

  7. relax python version for snowpark 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    cb320bd View commit details
    Browse the repository at this point in the history

  8. downgrade snowpark to 1.22 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    628def6 View commit details
    Browse the repository at this point in the history

  9. upgrade cloudpickle to 2.2.1 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    136fb09 View commit details
    Browse the repository at this point in the history

  10. feat(datasets): create separate ibis.FileDataset (kedro-org#842) 

    * feat(datasets): create separate `ibis.FileDataset`

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): deprecate `TableDataset` file I/O

Signed-off-by: Deepyaman Datta <[email protected]>

* feat(datasets): implement `FileDataset` versioning

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): try `os.path.exists`, for Windows

Signed-off-by: Deepyaman Datta <[email protected]>

* revert(datasets): use pathlib, ignore Windows test

Refs: b7ff0c7

Signed-off-by: Deepyaman Datta <[email protected]>

* docs(datasets): add `ibis.FileDataset` to contents

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): add docstring for `hashable` func

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): add docstring for `hashable` func

Signed-off-by: Deepyaman Datta <[email protected]>

* feat(datasets)!: expose `load` and `save` publicly

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): remove second filepath assignment

Signed-off-by: Deepyaman Datta <[email protected]>

---------

Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: tdhooghe <[email protected]>
    @deepyaman @tdhooghe
    deepyaman authored and tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fe3bfbe View commit details
    Browse the repository at this point in the history

  11. ci(docker): Update error code in e2e test (kedro-org#888) 

    Update error code in e2e test

Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: tdhooghe <[email protected]>
    @ankatiyar @tdhooghe
    ankatiyar authored and tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fce2974 View commit details
    Browse the repository at this point in the history

  12. update docstring 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    60b4a86 View commit details
    Browse the repository at this point in the history

  13. test ci/cd without python version 3.12 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3e578c6 View commit details
    Browse the repository at this point in the history

  14. fix linting error 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a161191 View commit details
    Browse the repository at this point in the history

  15. add max python version for compatibility 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e4509bc View commit details
    Browse the repository at this point in the history

  16. fix error 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c98aef8 View commit details
    Browse the repository at this point in the history

  17. chore: Update PR template with checkbox for core dataset contribution (… 

    …kedro-org#891)

* Update PR template with checkbox for core dataset contribution

Signed-off-by: Merel Theisen <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Deepyaman Datta <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>

* Fix lint

Signed-off-by: Merel Theisen <[email protected]>

---------

Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Co-authored-by: Deepyaman Datta <[email protected]>
Signed-off-by: tdhooghe <[email protected]>
    @merelcht @deepyaman @tdhooghe
    2 people authored and tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e4f1c3c View commit details
    Browse the repository at this point in the history

  18. ci(datasets): Fix mypy errors (kedro-org#893) 

    Signed-off-by: tdhooghe <[email protected]>
    @ankatiyar @tdhooghe
    ankatiyar authored and tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bcec735 View commit details
    Browse the repository at this point in the history

  19. fix(datasets): default to DuckDB in in-memory mode (kedro-org#897) 

    * fix(datasets): default to DuckDB in in-memory mode

Signed-off-by: Deepyaman Datta <[email protected]>

* test(datasets): use `object()` sentinel as default

Signed-off-by: Deepyaman Datta <[email protected]>

* docs(datasets): add default database to RELEASE.md

Signed-off-by: Deepyaman Datta <[email protected]>

---------

Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: tdhooghe <[email protected]>
    @deepyaman @tdhooghe
    deepyaman authored and tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c243c6e View commit details
    Browse the repository at this point in the history

  20. build(datasets): make Kedro-Datasets 5.1.0 release (kedro-org#887) 

    Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: tdhooghe <[email protected]>
    @deepyaman @tdhooghe
    deepyaman authored and tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    388f455 View commit details
    Browse the repository at this point in the history

  21. ci: Add GH action to check for TSC votes on core dataset changes (ked… 

    …ro-org#896)

* Add GH action to check for TSC votes on core dataset changes
* Ignore TSC vote action in gatekeeper
* Trigger TSC vote action only on changes in core dataset

---------

Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: tdhooghe <[email protected]>
    @merelcht @tdhooghe
    merelcht authored and tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3c85b1f View commit details
    Browse the repository at this point in the history

  22. update testing framework and docstrings 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    101696c View commit details
    Browse the repository at this point in the history

  23. Update kedro-datasets/kedro_datasets/snowflake/snowpark_dataset.py 

    Signed-off-by: Thomas <[email protected]>
Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c1eeb77 View commit details
    Browse the repository at this point in the history

  24. validate and check table name for nones 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b9bf73e View commit details
    Browse the repository at this point in the history

  25. remove breakpoint 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2c804c9 View commit details
    Browse the repository at this point in the history

  26. change doc type hinting for tests to pass 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7b7811d View commit details
    Browse the repository at this point in the history

  27. feat(datasets): create separate ibis.FileDataset (kedro-org#842) 

    * feat(datasets): create separate `ibis.FileDataset`

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): deprecate `TableDataset` file I/O

Signed-off-by: Deepyaman Datta <[email protected]>

* feat(datasets): implement `FileDataset` versioning

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): try `os.path.exists`, for Windows

Signed-off-by: Deepyaman Datta <[email protected]>

* revert(datasets): use pathlib, ignore Windows test

Refs: b7ff0c7

Signed-off-by: Deepyaman Datta <[email protected]>

* docs(datasets): add `ibis.FileDataset` to contents

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): add docstring for `hashable` func

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): add docstring for `hashable` func

Signed-off-by: Deepyaman Datta <[email protected]>

* feat(datasets)!: expose `load` and `save` publicly

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): remove second filepath assignment

Signed-off-by: Deepyaman Datta <[email protected]>

---------

Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: tdhooghe <[email protected]>
    @deepyaman @tdhooghe
    deepyaman authored and tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    23b056a View commit details
    Browse the repository at this point in the history

  28. ci(datasets): Fix mypy errors (kedro-org#893) 

    Signed-off-by: tdhooghe <[email protected]>
    @ankatiyar @tdhooghe
    ankatiyar authored and tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    27e58cd View commit details
    Browse the repository at this point in the history

  29. more strict type hinting and casting for linting 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    178f0f4 View commit details
    Browse the repository at this point in the history

  30. add back python 3.12 to see if it is compatible 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0133025 View commit details
    Browse the repository at this point in the history

  31. update testing documentation 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fc2b3b8 View commit details
    Browse the repository at this point in the history

  32. Merge branch 'main' into feature/save-pd-to-snowflaketable 

    Signed-off-by: Merel Theisen <[email protected]>
    @merelcht
    merelcht authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c18fc13 View commit details
    Browse the repository at this point in the history

  33. remove uv lock 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7efd162 View commit details
    Browse the repository at this point in the history

  34. Merge remote-tracking branch 'refs/remotes/origin/feature/save-pd-to-… 

    …snowflaketable' into feature/save-pd-to-snowflaketable
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f9f3d40 View commit details
    Browse the repository at this point in the history

  35. remove unnecessary change to ibis file 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    620b27a View commit details
    Browse the repository at this point in the history

  36. Update kedro-datasets/kedro_datasets/snowflake/snowpark_dataset.py 

    Signed-off-by: Thomas <[email protected]>
    @tdhooghe
    tdhooghe authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4d514d9 View commit details
    Browse the repository at this point in the history

  37. Update kedro-datasets/kedro_datasets/snowflake/snowpark_dataset.py 

    Signed-off-by: Thomas <[email protected]>
    @tdhooghe
    tdhooghe authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2fddf19 View commit details
    Browse the repository at this point in the history

  38. touch as little reqs ass possible 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e25be21 View commit details
    Browse the repository at this point in the history

  39. update changelog 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e3bf820 View commit details
    Browse the repository at this point in the history

  40. bump cloudpickle version to enable snowpark 1.23 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1e0f0c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. better formatting of release 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    00832f7 View commit details
    Browse the repository at this point in the history

  2. skip tests if python geq 3.12 as not supported by snowpark 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    db5554e View commit details
    Browse the repository at this point in the history

  3. try except block for snowpark imports 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6230dfb View commit details
    Browse the repository at this point in the history

  4. put name in right place 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    edd2703 View commit details
    Browse the repository at this point in the history

  5. add import of snowflaketabledataset in try except block as well 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    94d7360 View commit details
    Browse the repository at this point in the history

  6. add if statement to only execute code when snowpark is available 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7a014c4 View commit details
    Browse the repository at this point in the history

  7. remove ignore of snowflake in makefile and update test execution logic 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    57ccd10 View commit details
    Browse the repository at this point in the history

  8. change makefile to include snowflake doctest 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f09c96e View commit details
    Browse the repository at this point in the history

  9. add if statement also in original code 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    698167d View commit details
    Browse the repository at this point in the history

  10. add snowflake available after succesful import 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5a0dcf8 View commit details
    Browse the repository at this point in the history

  11. remove try except blocks in code 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    076921e View commit details
    Browse the repository at this point in the history

  12. echo python version for debugging 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    004c5e5 View commit details
    Browse the repository at this point in the history

  13. also skipifs for fixtures 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a25b693 View commit details
    Browse the repository at this point in the history

  14. echo python version in cicd 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fa00b6e View commit details
    Browse the repository at this point in the history

  15. try with different make rule 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5e0c92a View commit details
    Browse the repository at this point in the history

  16. revert changes to makefile 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fbc275d View commit details
    Browse the repository at this point in the history

  17. skip entire module pytest 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6b3e3f3 View commit details
    Browse the repository at this point in the history

  18. revert local changes 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d464909 View commit details
    Browse the repository at this point in the history

  19. make docstrings look nicer 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4810dc9 View commit details
    Browse the repository at this point in the history

  20. improve docstring and remove ignore from dataset-doctest 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0886454 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'main' into feature/save-pd-to-snowflaketable 

    Signed-off-by: Thomas <[email protected]>
    @tdhooghe
    tdhooghe authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    25c28c4 View commit details
    Browse the repository at this point in the history

  22. add back ignore snowflake for doctesting and remove unexpected additi… 

    …ons to pyproject.toml

Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    624baa7 View commit details
    Browse the repository at this point in the history

  23. only skip for python 3.12 or higher 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    80f7765 View commit details
    Browse the repository at this point in the history

  24. remove separate pytest skips as we have a module wide one 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ba0a030 View commit details
    Browse the repository at this point in the history

  25. remove test from omit in pytproject.toml 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    36264c2 View commit details
    Browse the repository at this point in the history

  26. 100 test coverage 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fe43b5c View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. bump matplotlib to prevent installing test requirements from failing 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    10829ed View commit details
    Browse the repository at this point in the history

  2. revert matplotlib version bump 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    435159b View commit details
    Browse the repository at this point in the history

  3. exclude lines from coverage 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ba6975c View commit details
    Browse the repository at this point in the history

  4. only test python 3.12 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    52ce490 View commit details
    Browse the repository at this point in the history

  5. omit snowflake testing from python 3.12 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    71a3801 View commit details
    Browse the repository at this point in the history

  6. add python version check 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b89a552 View commit details
    Browse the repository at this point in the history

  7. fix bug in ignoreopts and add back python versions 3.10 and 3.11 in m… 

    …atrix

Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d967ff5 View commit details
    Browse the repository at this point in the history

  8. fix bug in ignoreopts and add back python versions 3.10 and 3.11 in m… 

    …atrix

Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    233b4f0 View commit details
    Browse the repository at this point in the history

  9. revert requires-python to 3.10 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7349fac View commit details
    Browse the repository at this point in the history

  10. ignore entire folder 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e64551e View commit details
    Browse the repository at this point in the history

  11. add back omit for snowflake as python 3.12 is not supported, hence ci… 

    …cd fails on coverage

Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ceacc8c View commit details
    Browse the repository at this point in the history

  12. revert makefile to original state 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e0735ad View commit details
    Browse the repository at this point in the history

  13. remove commented out setters 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d17b8a6 View commit details
    Browse the repository at this point in the history

  14. remove commented out fixtures 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c5c9e4d View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge branch 'main' into feature/save-pd-to-snowflaketable

    @tdhooghe
    tdhooghe authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fbc2545 View commit details
    Browse the repository at this point in the history

  2. remove commented out fixtures 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    67f24c0 View commit details
    Browse the repository at this point in the history

  3. skip test if import is missing 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    be5fb6f View commit details
    Browse the repository at this point in the history

  4. build: Bump matplotlib test dependency (kedro-org#904) 

    * Bump matplotlib test dependency

Signed-off-by: Merel Theisen <[email protected]>

* Fix matplotlib test

Signed-off-by: Merel Theisen <[email protected]>

---------

Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: tdhooghe <[email protected]>
    @merelcht @tdhooghe
    merelcht authored and tdhooghe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    217e60b View commit details
    Browse the repository at this point in the history

  5. remove snowpark from omit 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f288ab7 View commit details
    Browse the repository at this point in the history

  6. change snowpark to snowflake 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6a21d1f View commit details
    Browse the repository at this point in the history

  7. fix error in import or skip and add noqa for ruff 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0e2abe3 View commit details
    Browse the repository at this point in the history

  8. implement pr feedback to raise if data is not pandas or snowpark data… 

    …frame

Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c0c42a8 View commit details
    Browse the repository at this point in the history

  9. add back omit for snowflake as python 3.12 is not supported, hence ci… 

    …cd fails on coverage

Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    41dfa22 View commit details
    Browse the repository at this point in the history

  10. add test for new raising error 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0f3d838 View commit details
    Browse the repository at this point in the history

  11. process final pr comments 

    Signed-off-by: tdhooghe <[email protected]>
    @tdhooghe
    tdhooghe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2a688d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge branch 'main' into feature/save-pd-to-snowflaketable

    @merelcht
    merelcht authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a974010 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/save-pd-to-snowflaketable

    @merelcht
    merelcht authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    660a428 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Merge branch 'feature/save-pd-to-snowflaketable' of https://github.co… 

    …m/tdhooghe/kedro-plugins into feature/save-pd-to-snowflaketable
    @merelcht
    merelcht committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ecabf7d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/save-pd-to-snowflaketable

    @merelcht
    merelcht authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    fb6d73e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/save-pd-to-snowflaketable' of https://github.co… 

    …m/tdhooghe/kedro-plugins into feature/save-pd-to-snowflaketable
    @merelcht
    merelcht committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b6643a2 View commit details
    Browse the repository at this point in the history

  4. Fix lint by checking session for None 

    Signed-off-by: Merel Theisen <[email protected]>
    @merelcht
    merelcht committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    77567b7 View commit details
    Browse the repository at this point in the history