Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separated the Lint Dependencies for the Plugins #901

Merged

Conversation

MinuraPunchihewa
Copy link
Contributor

Description

This PR separates the lint dependencies for each plugin and allows users to install only the packages for required linting using the following command:
make install-lint-requirements plugin=kedro-<plugin>

This will avoid all of the bulky dependencies required for running the tests from also being installed when the need is only for linting.

Fixes #415

Development notes

These changes have been tested my manually running the above make command for each plugin.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@MinuraPunchihewa MinuraPunchihewa marked this pull request as ready for review October 21, 2024 15:38
@MinuraPunchihewa
Copy link
Contributor Author

Hey @astrojuanlu,
I believe I've been able to separate the lint dependencies. Let me know if I have missed any packages that are required for linting and if there is any documentation that I will need to update.

Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MinuraPunchihewa this is an elegant solution.

@MinuraPunchihewa
Copy link
Contributor Author

Thank you @MinuraPunchihewa this is an elegant solution.

I appreciate that, @SajidAlamQB. Thank you.

Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MinuraPunchihewa!
Trying to fix the lint failure so we can merge it

Signed-off-by: Ankita Katiyar <[email protected]>
@SajidAlamQB SajidAlamQB merged commit b1bae8d into kedro-org:main Oct 22, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate lint dependencies
3 participants