-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Separated the Lint Dependencies for the Plugins #901
feat: Separated the Lint Dependencies for the Plugins #901
Conversation
Signed-off-by: Minura Punchihewa <[email protected]>
Signed-off-by: Minura Punchihewa <[email protected]>
Signed-off-by: Minura Punchihewa <[email protected]>
Signed-off-by: Minura Punchihewa <[email protected]>
Signed-off-by: Minura Punchihewa <[email protected]>
Hey @astrojuanlu, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MinuraPunchihewa this is an elegant solution.
I appreciate that, @SajidAlamQB. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @MinuraPunchihewa!
Trying to fix the lint failure so we can merge it
Signed-off-by: Ankita Katiyar <[email protected]>
Description
This PR separates the lint dependencies for each plugin and allows users to install only the packages for required linting using the following command:
make install-lint-requirements plugin=kedro-<plugin>
This will avoid all of the bulky dependencies required for running the tests from also being installed when the need is only for linting.
Fixes #415
Development notes
These changes have been tested my manually running the above
make
command for each plugin.Checklist
RELEASE.md
file