Fix Unable to get file size when dataset has no protocol attribute
#2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
|
Added some thoughts on #1893 (comment) |
Signed-off-by: Sajid Alam <[email protected]>
SajidAlamQB
requested review from
rashidakanchwala and
ravi-kumar-pilla
as code owners
Signed-off-by: Sajid Alam <[email protected]>
ravi-kumar-pilla
approved these changes
Nov 7, 2024
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
astrojuanlu
reviewed
Nov 7, 2024
Signed-off-by: Sajid Alam <[email protected]>
rashidakanchwala
approved these changes
Nov 8, 2024
SajidAlamQB
deleted the
bugfix/handle-missing-protocols-for-DeltaTableDataset-
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to: #1893
User reported getting
Unable to get file size. Object has no attribute '_protocol'forDeltaTableDataset. This PR will aim to resolve it.Development notes
Stopped relying on methods from kedro that rely on private attribute, use
fsspecto find file size.QA notes
Checklist
RELEASE.mdfile