Rename all DataSet mentions to Dataset (excl. docs)
#3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
merelcht
changed the title
DataSet mentions to Dataset (exl. docs)DataSet mentions to Dataset (excl. docs)
deepyaman
reviewed
Oct 9, 2023
features/steps/test_starter/{{ cookiecutter.repo_name }}/conf/base/catalog.yml
Outdated
Show resolved
Hide resolved
deepyaman
reviewed
Oct 9, 2023
| @@ -176,9 +176,9 @@ def __init__( # noqa: too-many-arguments | |||
| Example: | |||
| :: | |||
|
|
|||
| >>> from kedro_datasets.pandas import CSVDataSet | |||
| >>> from kedro_datasets.pandas import CSVDataset | |||
There was a problem hiding this comment.
As commented in the other PR, these are dependent on the kedro_datasets version; do we feel 0.19.0 is a good time to just assume they have a new-enough kedro_datasets, or should this be communicated more clearly somewhere?
There was a problem hiding this comment.
I will create a PR to main to add messaging about this ahead of 0.19.0
deepyaman
reviewed
Oct 9, 2023
deepyaman
approved these changes
Oct 9, 2023
9 tasks
Co-authored-by: Deepyaman Datta <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
merelcht
requested review from
yetudada,
astrojuanlu and
stichbury
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves part of #2129
Will do the renaming in docs separately to limit the number of files changed: #3148
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile