Fix only six's major version #154
Conversation
| @@ -1,3 +1,3 @@ | |||
| pycryptodome>=3.4 | |||
| requests>=2.5,<3.0 | |||
| six~=1.10 | |||
| six>=1.10,<2.0 | |||
There was a problem hiding this comment.
May I ask, what does this have to do with six's major version? I may be incorrect, but I don't see the difference this change makes according to https://www.python.org/dev/peps/pep-0440/#compatible-release. Please elucidate.
There was a problem hiding this comment.
@masojus the current code is pinning to any (generally latest) version of 1.10.x. This PR is allowing 1.11.x, 1.12.x, etc.
The problem here is that it's causing conflicts during dependency resolution, so if I have a package that needs six > 1.11, I can't install both this package and the other, even though this package shouldn't be affected by updating six's minor version (second part of the version number).
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| setup( | |||
| name="keen", | |||
| version="0.5.1", | |||
| version="0.5.2", | |||
There was a problem hiding this comment.
Several other files have to change to release another minor version.
This PR changes the six dependency to fix only the major (1.X.Y) version. Libraries should not fix minor versions, it is a source of conflicts. If dependencies follow semver (which they should), upgrading a minor version should not break.