Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerating code: smart contract bindings and client's start help #3526

Closed
wants to merge 2 commits into from

Conversation

tomaszslabon
Copy link
Contributor

@tomaszslabon tomaszslabon commented Apr 17, 2023

Refs #3532

This PR adds missing generated code.
The code was generated using the make all command.

Note: return to this PR later when LightRelayMaintainerProxy is deployed and generate the bindings for mainnet.

@tomaszslabon tomaszslabon requested review from nkuba and pdyraga and removed request for nkuba April 17, 2023 10:39
@tomaszslabon tomaszslabon self-assigned this Apr 17, 2023
@tomaszslabon tomaszslabon marked this pull request as ready for review April 17, 2023 10:56
Comment on lines +1406 to +1408
func (_WalletRegistry *WalletRegistryTransactor) ForceAddWallet(opts *bind.TransactOpts, groupPubKey []byte, membersIdsHash [32]byte) (*types.Transaction, error) {
return _WalletRegistry.contract.Transact(opts, "forceAddWallet", groupPubKey, membersIdsHash)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a function from dApp-only contracts and it should not be in the development package.

It should definitely not be there for mainnet package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was described here: #3531

Until this is solved, as a workaround, please try generating contract bindings based on the mainnet package.

Copy link
Contributor Author

@tomaszslabon tomaszslabon Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to return to this PR later and generate the bindings based on the mainnet package.
At present, we cannot generate the bindings based on the mainnet package because we haven't deployed LightRelayMaintainerProxy yet and there is an error during generation.

@pdyraga pdyraga changed the title Added generated code Regenerating code: smart contract bindings and client's start help Apr 18, 2023
@tomaszslabon tomaszslabon marked this pull request as draft April 18, 2023 10:10
@pdyraga
Copy link
Member

pdyraga commented May 15, 2023

We regenerated smart contract bindings in other PRs.

To double-check everything is up-to-date, we will include contract binding regeneration as a part of the WalletCoordinator contract deployment scenario.

@pdyraga pdyraga closed this May 15, 2023
@pdyraga pdyraga deleted the generate-code branch May 15, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants