Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split contracts API doc into multiple files #3657

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

michalinacienciala
Copy link
Contributor

@michalinacienciala michalinacienciala commented Jun 28, 2023

Having all the contracts documented in one common file turned out to be hard to render by the GitBook. We're switching to documenting each contract file in a separate Markdown file.
As the generated files will be much smaller now and GitBook has its own file ON THIS PAGE section, we don't need to generate Table of Contents. The one thing that we also change as part of this PR is rsyncDelete setting - we'll have it set to true, in order to delete documentation of contracts which get removed from the repo. As we're not working directly on a main branch, this isn't dangerous (we'll see all the deletions in the PR diff).

Refs:
threshold-network/solidity-contracts#149
keep-network/tbtc-v2#640
threshold-network/threshold#36

@github-actions
Copy link

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/5402099144 check.

@github-actions
Copy link

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/5402099142 check.

@github-actions
Copy link

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/5402113668 check.

@github-actions
Copy link

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/5402113664 check.

@github-actions
Copy link

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/5402502186 check.

@github-actions
Copy link

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/5402502193 check.

@github-actions
Copy link

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/5402582338 check.

@github-actions
Copy link

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/5402582335 check.

Having all the contracts documented in one common file turned out to be hard to
render by the GitBook. We're switching to documenting each contract file in a
separate Markdown file.
As the generated files will be much smaller now and GitBook has its own file `ON
THIS PAGE` section, we don't need to generate Table of Contents.
The one thing that we also change as part of this PR is `rsyncDelete` setting -
we'll have it set to `true`, in order to delete documentation of contracts which
get removed from the repo. As we're not working directly on a `main` branch,
this isn't dangerous (we'll see all the delitions in the PR diff).
@github-actions
Copy link

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/5403544537 check.

@michalinacienciala
Copy link
Contributor Author

Docs updated in threshold-network/threshold#36.

@github-actions
Copy link

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/5403544533 check.

@pdyraga pdyraga merged commit f48d676 into main Jun 29, 2023
@pdyraga pdyraga deleted the split-api-docs-to-multiple-files branch June 29, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation People need to know things!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants